From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
David Miller <dmiller423@gmail.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: pasic@linux.ibm.com, borntraeger@linux.ibm.com,
farman@linux.ibm.com, cohuck@redhat.com, david@redhat.com
Subject: Re: [PATCH v3] tests/tcg/s390x: Cleanup of mie3 tests.
Date: Mon, 7 Mar 2022 07:50:14 -1000 [thread overview]
Message-ID: <6bbb469f-3043-6a7c-bfbe-c2bd5d138907@linaro.org> (raw)
In-Reply-To: <23a9e21b-5f2b-1945-1b04-8bf71a9c637b@redhat.com>
On 3/6/22 22:42, Thomas Huth wrote:
>> +asm volatile ( \
>> + "llihf %[res],801\n"\
>> + ASM \
>> + : [res] "=&r" (res) \
>> + : [a] "r" (a) \
>> + , [b] "r" (b) \
>> +); \
>
> Hmm, don't we still need "cc" in the clobber list? AFAICS some of these instructions still
> alter the CC register... so I'd suggest to rather drop the changes to this file?
Yep, my bad. I wrongly assumed cc would be auto-clobbered, like i386.
r~
prev parent reply other threads:[~2022-03-07 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 21:43 [PATCH v3] tests/tcg/s390x: Cleanup of mie3 tests David Miller
2022-03-01 22:18 ` Richard Henderson
2022-03-07 8:42 ` Thomas Huth
2022-03-07 17:50 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bbb469f-3043-6a7c-bfbe-c2bd5d138907@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmiller423@gmail.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).