From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Cleber Rosa <crosa@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/9] iotests: Make them work for both Python 2 and 3
Date: Tue, 16 Oct 2018 00:19:50 +0200 [thread overview]
Message-ID: <6be3d69f-1bb4-04c2-c1af-9afb8122753d@redhat.com> (raw)
In-Reply-To: <20181015141453.32632-1-mreitz@redhat.com>
Hi Max,
On 15/10/2018 16:14, Max Reitz wrote:
> This series prepares the iotests to work with both Python 2 and 3. In
> some places, it adds version-specific code and decides what to do based
> on the version (for instance, whether to import the StringIO class from
> the 'io' or the 'StringIO' module), but most of the time, it just makes
> code work for both versions in general.
>
> And when we make the switch to make Python 3 mandatory, we can simply
> drop the Python 2 branches.
>
>
> Max Reitz (9):
> iotests: Make nbd-fault-injector flush
> iotests: Flush in iotests.py's QemuIoInteractive
> iotests: Use Python byte strings where appropriate
> iotests: Use // for Python integer division
> iotests: Different iterator behavior in Python 3
> iotests: Explicitly inherit FDs in Python
> iotests: 'new' module replacement in 169
> iotests: Modify imports for Python 3
> iotests: Unify log outputs between Python 2 and 3
You forgot:
MAINTAINERS: Add myself in the Python scripts section
;)
>
> scripts/qemu.py | 13 +-
> scripts/qmp/qmp.py | 7 +
> scripts/qtest.py | 2 +-
> tests/qemu-iotests/040 | 4 +-
> tests/qemu-iotests/044 | 20 +-
> tests/qemu-iotests/056 | 2 +-
> tests/qemu-iotests/065 | 4 +-
> tests/qemu-iotests/083.out | 9 +
> tests/qemu-iotests/093 | 18 +-
> tests/qemu-iotests/124 | 4 +-
> tests/qemu-iotests/139 | 2 +-
> tests/qemu-iotests/147 | 7 +
> tests/qemu-iotests/149 | 14 +-
> tests/qemu-iotests/151 | 12 +-
> tests/qemu-iotests/163 | 8 +-
> tests/qemu-iotests/169 | 3 +-
> tests/qemu-iotests/194.out | 22 +-
> tests/qemu-iotests/202.out | 12 +-
> tests/qemu-iotests/203.out | 14 +-
> tests/qemu-iotests/206.out | 144 +++----
> tests/qemu-iotests/207 | 4 +-
> tests/qemu-iotests/207.out | 52 +--
> tests/qemu-iotests/208.out | 8 +-
> tests/qemu-iotests/210.out | 72 ++--
> tests/qemu-iotests/211.out | 66 +--
> tests/qemu-iotests/212.out | 102 ++---
> tests/qemu-iotests/213.out | 124 +++---
> tests/qemu-iotests/216.out | 4 +-
> tests/qemu-iotests/218.out | 20 +-
> tests/qemu-iotests/219.out | 526 +++++++++++------------
> tests/qemu-iotests/222.out | 24 +-
> tests/qemu-iotests/iotests.py | 64 ++-
> tests/qemu-iotests/nbd-fault-injector.py | 12 +-
> tests/qemu-iotests/qcow2.py | 10 +-
> 34 files changed, 745 insertions(+), 664 deletions(-)
>
next prev parent reply other threads:[~2018-10-15 22:20 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 14:14 [Qemu-devel] [PATCH 0/9] iotests: Make them work for both Python 2 and 3 Max Reitz
2018-10-15 14:14 ` [Qemu-devel] [PATCH 1/9] iotests: Make nbd-fault-injector flush Max Reitz
2018-10-15 19:42 ` Eduardo Habkost
2018-10-15 20:24 ` Cleber Rosa
2018-10-16 18:07 ` Eric Blake
2018-10-19 9:48 ` Max Reitz
2018-10-19 14:21 ` Eric Blake
2018-10-15 14:14 ` [Qemu-devel] [PATCH 2/9] iotests: Flush in iotests.py's QemuIoInteractive Max Reitz
2018-10-15 19:43 ` Eduardo Habkost
2018-10-15 20:49 ` Cleber Rosa
2018-10-15 14:14 ` [Qemu-devel] [PATCH 3/9] iotests: Use Python byte strings where appropriate Max Reitz
2018-10-15 19:53 ` Eduardo Habkost
2018-10-19 8:46 ` Max Reitz
2018-10-15 22:08 ` Philippe Mathieu-Daudé
2018-10-15 14:14 ` [Qemu-devel] [PATCH 4/9] iotests: Use // for Python integer division Max Reitz
2018-10-15 19:54 ` Eduardo Habkost
2018-10-15 21:13 ` Cleber Rosa
2018-10-19 9:06 ` Max Reitz
2018-10-15 14:14 ` [Qemu-devel] [PATCH 5/9] iotests: Different iterator behavior in Python 3 Max Reitz
2018-10-15 20:07 ` Eduardo Habkost
2018-10-19 8:52 ` Max Reitz
2018-10-15 22:39 ` Cleber Rosa
2018-10-19 9:42 ` Max Reitz
2018-10-15 14:14 ` [Qemu-devel] [PATCH 6/9] iotests: Explicitly inherit FDs in Python Max Reitz
2018-10-15 20:30 ` Eduardo Habkost
2018-10-19 9:03 ` Max Reitz
2018-10-15 23:18 ` Cleber Rosa
2018-10-19 9:43 ` Max Reitz
2018-10-15 14:14 ` [Qemu-devel] [PATCH 7/9] iotests: 'new' module replacement in 169 Max Reitz
2018-10-15 21:13 ` Eduardo Habkost
2018-10-15 23:38 ` Cleber Rosa
2018-10-15 23:57 ` Eduardo Habkost
2018-10-16 1:01 ` Cleber Rosa
2018-10-19 9:46 ` Max Reitz
2018-10-19 14:18 ` Eduardo Habkost
2018-10-15 14:14 ` [Qemu-devel] [PATCH 8/9] iotests: Modify imports for Python 3 Max Reitz
2018-10-15 18:59 ` Cleber Rosa
2018-10-15 20:15 ` Eduardo Habkost
2018-10-19 8:44 ` Max Reitz
2018-10-15 21:17 ` Eduardo Habkost
2018-10-16 0:05 ` Cleber Rosa
2018-10-16 0:12 ` Eduardo Habkost
2018-10-19 9:25 ` Max Reitz
2018-10-15 14:14 ` [Qemu-devel] [PATCH 9/9] iotests: Unify log outputs between Python 2 and 3 Max Reitz
2018-10-15 22:26 ` Eduardo Habkost
2018-10-19 9:33 ` Max Reitz
2018-10-15 22:19 ` Philippe Mathieu-Daudé [this message]
2018-10-19 9:08 ` [Qemu-devel] [PATCH 0/9] iotests: Make them work for both " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be3d69f-1bb4-04c2-c1af-9afb8122753d@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).