From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image
Date: Thu, 1 Feb 2018 13:18:23 -0600 [thread overview]
Message-ID: <6be652dd-d2c7-700f-cb7f-cfffb968b40f@redhat.com> (raw)
In-Reply-To: <8f78f816-a37e-e968-e844-a7088e87b9e4@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On 02/01/2018 11:59 AM, Max Reitz wrote:
>>> Hmmmm, now this fails again on my 32 bit build. :-(
>>>
>>> The issue there is that you get a "Cannot allocate memory" when trying
>>> to open the file. My current fix was 2291712c39111a732 which simply
>>> converted that to "Invalid argument", but now it's getting a bit more
>>> complicated... Should I just continue to play the game and check the
>>> output for "Cannot allocate memory" and print exactly what the reference
>>> output is expecting...?
>>
>> Ahhh. OK, then, with a big comment.
>>
>> I'd say let's just _notrun on 32 bit.
>
> Sounds OK, but how would we test that? uname? Or just _notrun when we
> see the ENOMEM message?
_notrun when you detect ENOMEM seems reasonable (the equivalent of exit
status 77 in skipping a test in an automake context)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-02-01 19:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 6:25 [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image Fam Zheng
2018-01-30 13:48 ` Eric Blake
2018-01-30 14:12 ` Fam Zheng
2018-01-30 16:26 ` Kevin Wolf
2018-01-31 18:58 ` Max Reitz
2018-02-01 0:55 ` Fam Zheng
2018-02-01 17:59 ` Max Reitz
2018-02-01 19:18 ` Eric Blake [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-24 4:42 Fam Zheng
2018-01-29 15:49 ` Kevin Wolf
2018-01-30 6:26 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be652dd-d2c7-700f-cb7f-cfffb968b40f@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).