qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Foley <pefoley@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
	nabihestefan@google.com
Subject: Re: [PATCH] linux-user: Add missing includes
Date: Fri, 5 Sep 2025 18:26:07 +0200	[thread overview]
Message-ID: <6be94329-73c5-425a-a890-1199ddcfe1f4@linaro.org> (raw)
In-Reply-To: <CAAAKUPPbiQnCzkmnL0Luww1qeFQxVojzfkgJPrGgphXpkrXMGQ@mail.gmail.com>

On 9/5/25 18:00, Peter Foley wrote:
> We're using glibc 2.27.

That's just too old.

commit c42e77a90d9244c8caf76fe0e54f84200430a4e1
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Tue Aug 8 09:44:18 2023 -0700

     qemu/osdep: Remove fallback for MAP_FIXED_NOREPLACE

     In order for our emulation of MAP_FIXED_NOREPLACE to succeed within
     linux-user target_mmap, we require a non-zero value.  This does not
     require host kernel support, merely the bit being defined.

     MAP_FIXED_NOREPLACE was added with glibc 2.28.  From repology.org:

                       Fedora 36: 2.35
               CentOS 8 (RHEL-8): 2.28
                       Debian 11: 2.31
              OpenSUSE Leap 15.4: 2.31
                Ubuntu LTS 20.04: 2.31

     Reported-by: Akihiko Odaki <akihiko.odaki@daynix.com>
     Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
     Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
     Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
     Message-Id: <20230808164418.69989-1-richard.henderson@linaro.org>


r~



  parent reply	other threads:[~2025-09-05 16:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 15:21 [PATCH] linux-user: Add missing includes Peter Foley
2025-09-05  7:31 ` Paolo Bonzini
2025-09-05  8:48   ` Richard Henderson
2025-09-05 16:00     ` Peter Foley
2025-09-05 16:06       ` Peter Foley
2025-09-05 16:26       ` Richard Henderson [this message]
2025-09-05 16:28         ` Peter Foley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6be94329-73c5-425a-a890-1199ddcfe1f4@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=nabihestefan@google.com \
    --cc=pbonzini@redhat.com \
    --cc=pefoley@google.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).