Re: [PATCH v2] aspeed: Deprecate the tacoma-bmc machine

["Cédric Le Goater" <clg@redhat.com>]

On 9/9/24 17:10, Guenter Roeck wrote:
> On 9/9/24 04:20, Joel Stanley wrote:
>> On Sat, 31 Aug 2024 at 05:41, Guenter Roeck <linux@roeck-us.net> wrote:
>>>
>>> On Fri, Aug 30, 2024 at 10:09:25AM +0200, Cédric Le Goater wrote:
>>>> Hello,
>>>>
>>>>
>>>>>>> I solved the problem by adding support for IBM Bonnell (which instantiates
>>>>>>> the TPM chip through its devicetree file, similar to tacoma-bmc) to my local
>>>>>>> copy of qemu.
>>>>>>
>>>>>> Hmm, did you copy the rainier-bmc machine definition ?
>>>>>>
>>>>> For aspeed_machine_bonnell_class_init(), pretty much yes, since I don't know
>>>>> the actual hardware. For I2C initialization I used the devicetree file.
>>>>> You can find the patch in the master-local or v9.1.0-local branches
>>>>> of my qemu clone at https://github.com/groeck/qemu if you are interested.
>>>>
>>>> Oh nice ! Let's merge the IBM Bonnell machine. We can ask IBM to help fixing
>>>> the definitions (strapping). Enabling the PCA9554 is good to have too.
>>
>> Instead of adding Bonnell to qemu, could we use the Rainier machine? I
>> know the kernel device tree removed the i2c tpm, but there's no harm
>> in it being present in the qemu machine.
>>
>> The bonnell device tree should boot fine on the rainier machine for
>> your purposes.
>>
> 
> Yes, I confirmed that works. Ok, I'll do that.

So I will drop the bonnell to avoid redundancy. Is that OK ?


Thanks,

C.