From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1DEAE75451 for ; Thu, 5 Oct 2023 16:36:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoRJi-00080a-Kn; Thu, 05 Oct 2023 12:35:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoRJh-000805-OE for qemu-devel@nongnu.org; Thu, 05 Oct 2023 12:35:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoRJe-0000gq-Oz for qemu-devel@nongnu.org; Thu, 05 Oct 2023 12:35:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696523709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sCrhJOfqqPzCpWvwXWV2+JQ3pb5ma66IvlpWVIXE7e0=; b=YSjwSxlN0SLSJEBj46UzoGqpIZik2ldjrUHeXGuDvXaN9kMvt/+VPvNMqUhu/HErt7BWiF vPW49fY1AGnmzc2Q4irCvie0YMBmBYYGbWKPh9Rc7lztPg83IMf2IREodcgFViQ3DhWRiF eOPsHTQX2XFVFcBo/NrcaY/yzHrh0RY= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-4yS82mpJMOi0e2lxJSegrg-1; Thu, 05 Oct 2023 12:35:03 -0400 X-MC-Unique: 4yS82mpJMOi0e2lxJSegrg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-65b08994e15so17484136d6.0 for ; Thu, 05 Oct 2023 09:35:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696523683; x=1697128483; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sCrhJOfqqPzCpWvwXWV2+JQ3pb5ma66IvlpWVIXE7e0=; b=MtAFs16WIld6uYBDAwzWZDpRbiW2yM9Jlzf6AMM22iIExe8C9oxBoMrKYu/bL/t3uP zCDd/foMwFX2Owoy8GpEcGRNCHVVC/znnoGHDf4OHKXAvtjnSLM7IeDP/7NQf+4KiL0k a93jVoeQdSXFHBpmtG298avEY/im3D8Ft+eegIvaq1Cqqna2gfKljrrXfMTcR3MkoAWw X1vqYLokUuniMLYrDQfivx7AoCCmglBfP3mHk5791RGSEQyCtUEDJogS8BIgaGTdsUa+ j7YfHy2pM2ZS5qx7Sc+eHTceB49OhtAgMtji/0SEg5KcZ0xywVLBnjgemdBWLk6a5pmk mX8g== X-Gm-Message-State: AOJu0Yy1RqO9IhvU3AbK7OoIZgAk0S92r7WOEYbbIy3BUOxdCQ23ylyn GI/2Go1pOLWPh3woPozLQjDG+4cH+s8tgU0KhKXrsdpb0siwK/nS4mMwJePgQYykcqwSw4Sz8rH UzqFw9gXAgfGN8TE= X-Received: by 2002:a0c:f4d2:0:b0:655:8ac4:2658 with SMTP id o18-20020a0cf4d2000000b006558ac42658mr4089943qvm.21.1696523683601; Thu, 05 Oct 2023 09:34:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6B0vs6EZwOgNiiYwMAqEHx2lL7rkj6aMswYzqQ3qDVgEYnCXqyvX4k8AteZisos/kr/DELQ== X-Received: by 2002:a0c:f4d2:0:b0:655:8ac4:2658 with SMTP id o18-20020a0cf4d2000000b006558ac42658mr4089902qvm.21.1696523683294; Thu, 05 Oct 2023 09:34:43 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id u1-20020a0c8dc1000000b0064743dd0633sm620535qvb.106.2023.10.05.09.34.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 09:34:42 -0700 (PDT) Message-ID: <6bfe37d7-eefb-08f7-0f74-e89b41fb8af3@redhat.com> Date: Thu, 5 Oct 2023 18:34:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 3/3] hw/vfio: add ramfb migration support Content-Language: en-US To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: kraxel@redhat.com, lersek@redhat.com, Eduardo Habkost , Marcel Apfelbaum , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Yanan Wang , Alex Williamson , Paolo Bonzini References: <20231005113027.1827078-1-marcandre.lureau@redhat.com> <20231005113027.1827078-4-marcandre.lureau@redhat.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20231005113027.1827078-4-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -62 X-Spam_score: -6.3 X-Spam_bar: ------ X-Spam_report: (-6.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.219, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/5/23 13:30, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Add a "VFIODisplay" subsection whenever "x-ramfb-migrate" is turned on. > > Turn it off by default on machines <= 8.1 for compatibility reasons. > > Signed-off-by: Marc-André Lureau > --- > hw/vfio/pci.h | 3 +++ > hw/core/machine.c | 1 + > hw/vfio/display.c | 20 ++++++++++++++++++++ > hw/vfio/pci.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > stubs/ramfb.c | 2 ++ > 5 files changed, 70 insertions(+) > > diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h > index 2d836093a8..fd06695542 100644 > --- a/hw/vfio/pci.h > +++ b/hw/vfio/pci.h > @@ -173,6 +173,7 @@ struct VFIOPCIDevice { > bool no_kvm_ioeventfd; > bool no_vfio_ioeventfd; > bool enable_ramfb; > + OnOffAuto ramfb_migrate; > bool defer_kvm_irq_routing; > bool clear_parent_atomics_on_exit; > VFIODisplay *dpy; > @@ -226,4 +227,6 @@ void vfio_display_reset(VFIOPCIDevice *vdev); > int vfio_display_probe(VFIOPCIDevice *vdev, Error **errp); > void vfio_display_finalize(VFIOPCIDevice *vdev); > > +extern const VMStateDescription vfio_display_vmstate; > + > #endif /* HW_VFIO_VFIO_PCI_H */ > diff --git a/hw/core/machine.c b/hw/core/machine.c > index e4361e3d48..f2c59a293c 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -33,6 +33,7 @@ > > GlobalProperty hw_compat_8_1[] = { > { "ramfb", "x-migrate", "off" }, > + { "vfio-pci-nohotplug", "x-ramfb-migrate", "off" } > }; > const size_t hw_compat_8_1_len = G_N_ELEMENTS(hw_compat_8_1); > > diff --git a/hw/vfio/display.c b/hw/vfio/display.c > index bec864f482..0bdb807642 100644 > --- a/hw/vfio/display.c > +++ b/hw/vfio/display.c > @@ -542,3 +542,23 @@ void vfio_display_finalize(VFIOPCIDevice *vdev) > vfio_display_edid_exit(vdev->dpy); > g_free(vdev->dpy); > } > + > +static bool migrate_needed(void *opaque) > +{ > + VFIODisplay *dpy = opaque; > + bool ramfb_exists = dpy->ramfb != NULL; > + > + /* see vfio_display_migration_needed() */ > + assert(ramfb_exists); > + return ramfb_exists; > +} > + > +const VMStateDescription vfio_display_vmstate = { > + .name = "VFIODisplay", > + .version_id = 1, > + .minimum_version_id = 1, > + .needed = migrate_needed, > + .fields = (VMStateField[]) { > + VMSTATE_STRUCT_POINTER(ramfb, VFIODisplay, ramfb_vmstate, RAMFBState), > + } > +}; > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 3b2ca3c24c..d2ede2f1a2 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -2608,6 +2608,32 @@ static bool vfio_msix_present(void *opaque, int version_id) > return msix_present(pdev); > } > > +static bool vfio_display_migration_needed(void *opaque) > +{ > + VFIOPCIDevice *vdev = opaque; > + > + /* > + * We need to migrate the VFIODisplay object if ramfb *migration* was > + * explicitly requested (in which case we enforced both ramfb=on and > + * display=on), or ramfb migration was left at the default "auto" > + * setting, and *ramfb* was explicitly requested (in which case we > + * enforced display=on). > + */ > + return vdev->ramfb_migrate == ON_OFF_AUTO_ON || > + (vdev->ramfb_migrate == ON_OFF_AUTO_AUTO && vdev->enable_ramfb);> +} > + > +const VMStateDescription vmstate_vfio_display = { > + .name = "VFIOPCIDevice/VFIODisplay", > + .version_id = 1, > + .minimum_version_id = 1, > + .needed = vfio_display_migration_needed, > + .fields = (VMStateField[]){ > + VMSTATE_STRUCT_POINTER(dpy, VFIOPCIDevice, vfio_display_vmstate, VFIODisplay), > + VMSTATE_END_OF_LIST() > + } > +}; > + > const VMStateDescription vmstate_vfio_pci_config = { > .name = "VFIOPCIDevice", > .version_id = 1, > @@ -2616,6 +2642,10 @@ const VMStateDescription vmstate_vfio_pci_config = { > VMSTATE_PCI_DEVICE(pdev, VFIOPCIDevice), > VMSTATE_MSIX_TEST(pdev, VFIOPCIDevice, vfio_msix_present), > VMSTATE_END_OF_LIST() > + }, > + .subsections = (const VMStateDescription*[]) { > + &vmstate_vfio_display, > + NULL > } > }; > > @@ -3271,6 +3301,19 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) > } > } > > + if (vdev->ramfb_migrate == ON_OFF_AUTO_ON && !vdev->enable_ramfb) { > + error_setg(errp, "x-ramfb-migrate requires ramfb=on"); This is a case where QEMU would be run from the command line. Could we ouput a warning and force "ramfb_migrate" to OFF in that case ? since the machine would still run. Thanks, C. > + goto out_deregister; > + } > + if (vbasedev->enable_migration == ON_OFF_AUTO_OFF) { > + if (vdev->ramfb_migrate == ON_OFF_AUTO_AUTO) { > + vdev->ramfb_migrate = ON_OFF_AUTO_OFF; > + } else if (vdev->ramfb_migrate == ON_OFF_AUTO_ON) { > + error_setg(errp, "x-ramfb-migrate requires enable-migration"); > + goto out_deregister; > + } > + } > + > if (!pdev->failover_pair_id) { > if (!vfio_migration_realize(vbasedev, errp)) { > goto out_deregister; > @@ -3484,6 +3527,7 @@ static const TypeInfo vfio_pci_dev_info = { > > static Property vfio_pci_dev_nohotplug_properties[] = { > DEFINE_PROP_BOOL("ramfb", VFIOPCIDevice, enable_ramfb, false), > + DEFINE_PROP_ON_OFF_AUTO("x-ramfb-migrate", VFIOPCIDevice, ramfb_migrate, ON_OFF_AUTO_AUTO), > DEFINE_PROP_END_OF_LIST(), > }; > > diff --git a/stubs/ramfb.c b/stubs/ramfb.c > index 48143f3354..cf64733b10 100644 > --- a/stubs/ramfb.c > +++ b/stubs/ramfb.c > @@ -2,6 +2,8 @@ > #include "qapi/error.h" > #include "hw/display/ramfb.h" > > +const VMStateDescription ramfb_vmstate = {}; > + > void ramfb_display_update(QemuConsole *con, RAMFBState *s) > { > }