From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] shippable: fix build
Date: Wed, 20 Feb 2019 19:00:19 +0100 [thread overview]
Message-ID: <6c04a73b-b0f3-2a7d-443e-337e8b637c27@redhat.com> (raw)
In-Reply-To: <87lg2a4amz.fsf@zen.linaroharston>
On 2/20/19 6:45 PM, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
>> On 2/20/19 5:37 PM, Alex Bennée wrote:
>>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>>
>>>> It looks like something in netmap has changed and compilation fails:
>>>>
>>>> install -D libnetmap.a //usr/local/lib/libnetmap.a
>>>> install: cannot stat libnetmap.a: No such file or directory
>>>>
>>>> Add an explicit "make" step to fix it.
>>>
>>> I took an alternate approach as tracking another projects master seems
>>> like a bad idea:
>>>
>>> tests/docker: peg netmap code to a specific version
>>>
>>> Tracking head is always going to be at the whims of the upstream.
>>> Let's use a defined release so things don't magically change under us.
>>
>> Oh now I see your reply...
>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>>
>>> 1 file changed, 1 insertion(+)
>>> tests/docker/dockerfiles/debian-amd64.docker | 1 +
>>>
>>> modified tests/docker/dockerfiles/debian-amd64.docker
>>> @@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
>>> apt-get install -y --no-install-recommends \
>>> linux-headers-amd64
>>> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
>>> +RUN cd /usr/src/netmap && git checkout v11.3
>>
>> ... and I notice I forgot to change directory in my previous suggestion.
>>
>> Why do you take v11.3 and not v11.4?
>> I agree v11.3 was closer to what I tested when I introduced this
>> dependency, but I'd rather use the latest release.
>
> Hmm github hid the newer releases by default and has a Latest Release
> button by v11.3.
I don't understand (this GitHub feature)...
I'm talking about this release:
https://github.com/luigirizzo/netmap/releases/tag/v11.4
The date is more recent that the v11.3. This looks like the latest
release to me.
Anyway I'm fine if you prefer v11.3.
Please send a formal patch because I don't want to confuse scripts
adding my R-b in Paolo's patch.
Regards,
Phil.
next prev parent reply other threads:[~2019-02-20 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 10:45 [Qemu-devel] [PATCH] shippable: fix build Paolo Bonzini
2019-02-20 16:37 ` Alex Bennée
2019-02-20 17:24 ` Philippe Mathieu-Daudé
2019-02-20 17:45 ` Alex Bennée
2019-02-20 18:00 ` Philippe Mathieu-Daudé [this message]
2019-02-21 9:14 ` Stefano Garzarella
2019-02-21 9:24 ` Vincenzo Maffione
2019-02-20 17:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c04a73b-b0f3-2a7d-443e-337e8b637c27@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).