From: Paolo Bonzini <pbonzini@redhat.com>
To: luoyonggang@gmail.com
Cc: qemu-level <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson
Date: Fri, 18 Sep 2020 15:20:57 +0200 [thread overview]
Message-ID: <6c21e60d-9bc9-e90d-5df1-31345cee7a7a@redhat.com> (raw)
In-Reply-To: <CAE2XoE82=BjoGF5sXUBE+rTJzDwphBRL8CqRp2Z9FAq83dHXJw@mail.gmail.com>
On 18/09/20 14:55, 罗勇刚(Yonggang Luo) wrote:
>
>> if test "$tcmalloc" = "yes" && test "$jemalloc" = "yes" ; then
>> echo "ERROR: tcmalloc && jemalloc can't be used at the same time"
>> exit 1
>> -fi
> This patch looks good for me, but I still have a small advice than move
> thse judgement from
> configure to meson, because finally they need to be converted.
> and getting tcmalloc / jemalloc to be "enabled" "disabled" for consistence
>
This error cannot apply to meson.build because it uses a single
multi-choice option "-Dmalloc=system|tcmalloc|jemalloc".
Paolo
prev parent reply other threads:[~2020-09-18 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 8:06 [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson Paolo Bonzini
2020-09-16 8:58 ` Stefan Hajnoczi
2020-09-16 16:01 ` Richard Henderson
2020-09-18 12:55 ` 罗勇刚(Yonggang Luo)
2020-09-18 13:20 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c21e60d-9bc9-e90d-5df1-31345cee7a7a@redhat.com \
--to=pbonzini@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).