From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH-for-11.0 v3 22/22] accel/tcg: Remove non-explicit endian cpu_ld/st*_data*() helpers
Date: Fri, 12 Dec 2025 11:02:42 -0600 [thread overview]
Message-ID: <6c2e05cc-608b-4835-a37f-be0164ab50eb@linaro.org> (raw)
In-Reply-To: <d6d5cd40-ac5c-41f2-85f9-db038fa8b5a6@linaro.org>
On 11/26/25 14:32, Philippe Mathieu-Daudé wrote:
> On 26/11/25 21:21, Philippe Mathieu-Daudé wrote:
>> All uses were converted to the explicit cpu_ld/st*_{be,le}_data*()
>> helpers, no need for the non-explicit versions anymore.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> include/accel/tcg/cpu-ldst.h | 46 ------------------------------------
>> 1 file changed, 46 deletions(-)
>>
>> diff --git a/include/accel/tcg/cpu-ldst.h b/include/accel/tcg/cpu-ldst.h
>> index 0de7f5eaa6b..12dd38599a6 100644
>> --- a/include/accel/tcg/cpu-ldst.h
>> +++ b/include/accel/tcg/cpu-ldst.h
>> @@ -428,52 +428,6 @@ cpu_stq_le_data(CPUArchState *env, abi_ptr addr, uint64_t val)
>> cpu_stq_le_data_ra(env, addr, val, 0);
>> }
>> -#if TARGET_BIG_ENDIAN
>> -# define cpu_lduw_data cpu_lduw_be_data
>> -# define cpu_ldsw_data cpu_ldsw_be_data
>> -# define cpu_ldl_data cpu_ldl_be_data
>> -# define cpu_ldq_data cpu_ldq_be_data
>> -# define cpu_lduw_data_ra cpu_lduw_be_data_ra
>> -# define cpu_ldsw_data_ra cpu_ldsw_be_data_ra
>> -# define cpu_ldl_data_ra cpu_ldl_be_data_ra
>> -# define cpu_ldq_data_ra cpu_ldq_be_data_ra
>> -# define cpu_lduw_mmuidx_ra cpu_lduw_be_mmuidx_ra
>> -# define cpu_ldsw_mmuidx_ra cpu_ldsw_be_mmuidx_ra
>> -# define cpu_ldl_mmuidx_ra cpu_ldl_be_mmuidx_ra
>> -# define cpu_ldq_mmuidx_ra cpu_ldq_be_mmuidx_ra
>> -# define cpu_stw_data cpu_stw_be_data
>> -# define cpu_stl_data cpu_stl_be_data
>> -# define cpu_stq_data cpu_stq_be_data
>> -# define cpu_stw_data_ra cpu_stw_be_data_ra
>> -# define cpu_stl_data_ra cpu_stl_be_data_ra
>> -# define cpu_stq_data_ra cpu_stq_be_data_ra
>> -# define cpu_stw_mmuidx_ra cpu_stw_be_mmuidx_ra
>> -# define cpu_stl_mmuidx_ra cpu_stl_be_mmuidx_ra
>> -# define cpu_stq_mmuidx_ra cpu_stq_be_mmuidx_ra
>> -#else
>> -# define cpu_lduw_data cpu_lduw_le_data
>> -# define cpu_ldsw_data cpu_ldsw_le_data
>> -# define cpu_ldl_data cpu_ldl_le_data
>> -# define cpu_ldq_data cpu_ldq_le_data
>> -# define cpu_lduw_data_ra cpu_lduw_le_data_ra
>> -# define cpu_ldsw_data_ra cpu_ldsw_le_data_ra
>> -# define cpu_ldl_data_ra cpu_ldl_le_data_ra
>> -# define cpu_ldq_data_ra cpu_ldq_le_data_ra
>> -# define cpu_lduw_mmuidx_ra cpu_lduw_le_mmuidx_ra
>> -# define cpu_ldsw_mmuidx_ra cpu_ldsw_le_mmuidx_ra
>> -# define cpu_ldl_mmuidx_ra cpu_ldl_le_mmuidx_ra
>> -# define cpu_ldq_mmuidx_ra cpu_ldq_le_mmuidx_ra
>> -# define cpu_stw_data cpu_stw_le_data
>> -# define cpu_stl_data cpu_stl_le_data
>> -# define cpu_stq_data cpu_stq_le_data
>> -# define cpu_stw_data_ra cpu_stw_le_data_ra
>> -# define cpu_stl_data_ra cpu_stl_le_data_ra
>> -# define cpu_stq_data_ra cpu_stq_le_data_ra
>> -# define cpu_stw_mmuidx_ra cpu_stw_le_mmuidx_ra
>> -# define cpu_stl_mmuidx_ra cpu_stl_le_mmuidx_ra
>> -# define cpu_stq_mmuidx_ra cpu_stq_le_mmuidx_ra
>> -#endif
>> -
>
> Missing to squash:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
>
> -- >8 --
> diff --git a/docs/devel/loads-stores.rst b/docs/devel/loads-stores.rst
> index c906c6509ee..e956aece673 100644
> --- a/docs/devel/loads-stores.rst
> +++ b/docs/devel/loads-stores.rst
> @@ -152,3 +152,3 @@ store: ``cpu_st{size}{end}_mmuidx_ra(env, ptr, val, mmuidx, retaddr)``
> ``end``
> - - (empty) : for target endian, or 8 bit sizes
> + - (empty) : for 8 bit sizes
> - ``_be`` : big endian
> @@ -157,4 +157,4 @@ store: ``cpu_st{size}{end}_mmuidx_ra(env, ptr, val, mmuidx, retaddr)``
> Regexes for git grep:
> - - ``\<cpu_ld[us]\?[bwlq]\(_[bl]e\)\?_mmuidx_ra\>``
> - - ``\<cpu_st[bwlq]\(_[bl]e\)\?_mmuidx_ra\>``
> + - ``\<cpu_ld[us]\?\(b\|[wlq]\(_[bl]e\)\)_mmuidx_ra\>``
> + - ``\<cpu_st\(b\|[wlq]\(_[bl]e\)\)_mmuidx_ra\>``
>
> @@ -190,3 +190,3 @@ store: ``cpu_st{size}{end}_data_ra(env, ptr, val, ra)``
> ``end``
> - - (empty) : for target endian, or 8 bit sizes
> + - (empty) : for 8 bit sizes
> - ``_be`` : big endian
> @@ -195,4 +195,4 @@ store: ``cpu_st{size}{end}_data_ra(env, ptr, val, ra)``
> Regexes for git grep:
> - - ``\<cpu_ld[us]\?[bwlq]\(_[bl]e\)\?_data_ra\>``
> - - ``\<cpu_st[bwlq]\(_[bl]e\)\?_data_ra\>``
> + - ``\<cpu_ld[us]\?\(b\|[wlq]\(_[bl]e\)\)_data_ra\>``
> + - ``\<cpu_st\(b\|[wlq]\(_[bl]e\)\)_data_ra\>``
>
> @@ -229,3 +229,3 @@ store: ``cpu_st{size}{end}_data(env, ptr, val)``
> ``end``
> - - (empty) : for target endian, or 8 bit sizes
> + - (empty) : for 8 bit sizes
> - ``_be`` : big endian
> @@ -234,4 +234,4 @@ store: ``cpu_st{size}{end}_data(env, ptr, val)``
> Regexes for git grep:
> - - ``\<cpu_ld[us]\?[bwlq]\(_[bl]e\)\?_data\>``
> - - ``\<cpu_st[bwlq]\(_[bl]e\)\?_data\+\>``
> + - ``\<cpu_ld[us]\?\(b\|[wlq]\(_[bl]e\)\)_data\>``
> + - ``\<cpu_st\(b\|[wlq]\(_[bl]e\)\)_data\+\>``
> ---
prev parent reply other threads:[~2025-12-12 17:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 20:21 [PATCH-for-11.0 v3 00/22] accel/tcg: Remove most MO_TE uses in cpu_ld/st_data() Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 01/22] target/hexagon: Use little-endian variant of cpu_ld/st_data*() Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 02/22] target/i386: " Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 03/22] target/riscv: Use little-endian variant of cpu_ld/st_data*() for vector Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 04/22] target/rx: Use little-endian variant of cpu_ld/st_data*() Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 05/22] target/tricore: " Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 06/22] target/hppa: Use big-endian " Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 07/22] target/m68k: " Philippe Mathieu-Daudé
2025-12-05 20:02 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 08/22] target/s390x: " Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 09/22] target/sparc: " Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 10/22] target/sh4: Replace cpu_stl_data() call in OCBI helper Philippe Mathieu-Daudé
2025-12-05 20:03 ` Richard Henderson
2025-12-05 20:06 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 11/22] target/mips: Use big-endian variant of cpu_ld/st_data*() for MSA opcode Philippe Mathieu-Daudé
2025-12-12 16:28 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 12/22] target/mips: Introduce loadu8() & loads4() helpers Philippe Mathieu-Daudé
2025-12-12 16:32 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 13/22] target/mips: Pass MemOpIdx to atomic load helpers Philippe Mathieu-Daudé
2025-12-12 16:33 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 14/22] target/mips: Drop almask argument of HELPER_LD_ATOMIC() macro Philippe Mathieu-Daudé
2025-12-12 16:35 ` Richard Henderson
2025-12-12 16:43 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 15/22] target/mips: Inline cpu_ld*_mmuidx_ra() calls in atomic load helpers Philippe Mathieu-Daudé
2025-11-26 20:21 ` [PATCH-for-11.0 v3 16/22] target/mips: Expand HELPER_LD_ATOMIC() Philippe Mathieu-Daudé
2025-12-12 16:46 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 17/22] target/mips: Inline cpu_ld/st_mmuidx_ra() calls in memory helpers Philippe Mathieu-Daudé
2025-12-12 16:55 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 18/22] target/ppc: Inline cpu_ld/st_data_ra() calls in do_hash() Philippe Mathieu-Daudé
2025-12-12 16:57 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 19/22] target/ppc: Inline cpu_ld/st_mmuidx_ra() calls in memory helpers Philippe Mathieu-Daudé
2025-12-12 16:59 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 20/22] target/ppc: Inline cpu_ldl_data_ra() calls in ICBI helper Philippe Mathieu-Daudé
2025-12-12 17:01 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 21/22] target/ppc: Simplify endianness handling in Altivec opcodes Philippe Mathieu-Daudé
2025-12-12 17:02 ` Richard Henderson
2025-11-26 20:21 ` [PATCH-for-11.0 v3 22/22] accel/tcg: Remove non-explicit endian cpu_ld/st*_data*() helpers Philippe Mathieu-Daudé
2025-11-26 20:32 ` Philippe Mathieu-Daudé
2025-12-12 17:02 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c2e05cc-608b-4835-a37f-be0164ab50eb@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).