From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: zhao1.liu@intel.com
Subject: Re: [PATCH 1/4] target/i386: move max_features to class
Date: Fri, 11 Jul 2025 09:52:01 +0800 [thread overview]
Message-ID: <6c381d13-db0e-4b61-b72b-bda9e7727143@intel.com> (raw)
In-Reply-To: <20250711000603.438312-2-pbonzini@redhat.com>
On 7/11/2025 8:06 AM, Paolo Bonzini wrote:
> max_features is always set to true for instances created by -cpu max or
> -cpu host; it's always false for other classes. Therefore it can be
> turned into a field in the X86CPUClass.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
missed one place:
----------------8<---------------
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -8302,7 +8302,7 @@ void x86_cpu_expand_features(X86CPU *cpu, Error
**errp)
}
}
- /*TODO: Now cpu->max_features doesn't overwrite features
+ /*TODO: Now xcc->max_features doesn't overwrite features
* set using QOM properties, and we can convert
* plus_features & minus_features to global properties
* inside x86_cpu_parse_featurestr() too.
with above added,
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
next prev parent reply other threads:[~2025-07-11 1:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 0:05 [PATCH 0/4] target/i386: fix position of accel_cpu_instance_init Paolo Bonzini
2025-07-11 0:06 ` [PATCH 1/4] target/i386: move max_features to class Paolo Bonzini
2025-07-11 1:52 ` Xiaoyao Li [this message]
2025-07-11 3:43 ` Zhao Liu
2025-07-11 0:06 ` [PATCH 2/4] target/i386: nvmm, whpx: add accel/CPU class that sets host vendor Paolo Bonzini
2025-07-11 2:12 ` Xiaoyao Li
2025-07-11 2:17 ` Xiaoyao Li
2025-07-11 6:35 ` Paolo Bonzini
2025-07-11 6:40 ` Xiaoyao Li
2025-07-11 7:46 ` Paolo Bonzini
2025-07-11 5:36 ` Zhao Liu
2025-07-11 0:06 ` [PATCH 3/4] target/i386: allow reordering max_x86_cpu_initfn vs accel CPU init Paolo Bonzini
2025-07-11 2:20 ` Xiaoyao Li
2025-07-11 6:08 ` Zhao Liu
2025-07-11 0:06 ` [PATCH 4/4] target/i386: move accel_cpu_instance_init to .instance_init Paolo Bonzini
2025-07-11 2:26 ` Xiaoyao Li
2025-07-11 6:37 ` Paolo Bonzini
2025-07-11 6:32 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c381d13-db0e-4b61-b72b-bda9e7727143@intel.com \
--to=xiaoyao.li@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).