From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34F23C4332F for ; Mon, 6 Nov 2023 07:18:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qztrx-0007Mg-F1; Mon, 06 Nov 2023 02:17:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qztru-0007IF-U0 for qemu-devel@nongnu.org; Mon, 06 Nov 2023 02:17:54 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qztrt-0005PY-DG for qemu-devel@nongnu.org; Mon, 06 Nov 2023 02:17:54 -0500 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-32f7abbb8b4so2654758f8f.0 for ; Sun, 05 Nov 2023 23:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699255072; x=1699859872; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hodLEJrIrf1SgrJbrg7bPvIrnsFm+jWdxqkcAuAiGj8=; b=nGju9Cg+nxKNJaQaET2IBil0SW6qEqnZvG+HpkiZ/GeFyO1QxUBcciWYhkxkxUs5/7 E7rFYA7A0lKDe43Mnv9qwY58hCSeNYHgLUuQ0Lw8x72xnZflEafBAoM4Wiw9a1WeegJI kikLHYfFP51XTy+BqOt7NOvK9fNopTAZuLNu0Yj32vytJHWb6oI22GkVfxS/DypsnuhE jsWQM9xQUI+AdlK07sxaCiMlKxahElw42c8LWsB1ee9n9CQpY9NA8Cn04dJOL4HQP+E6 VeAsBmxV3O/FuzBO+ni1Amae74Se7KvD5TIwOhTnlwsJ0/hgXwYGEtTVq+cr75ScpixF hllg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699255072; x=1699859872; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hodLEJrIrf1SgrJbrg7bPvIrnsFm+jWdxqkcAuAiGj8=; b=Vw2xzo2DgHtb74x+gSoe2tsArsFz5V/YBlUzqwXregDozdvjhCXhlEUG6SBNO4H/wd fr7eqdFWhxrjQzOrU2Bswf+DWwLowo2697UuGIVPWrXhnwMlWxIiCet7d1ITw/NpHvgQ K4QGSY5tYcuCNxJXG5dsYQ2SgpJ5/dD7NuweL/NmzKaImV0Ty1yz858wc/NFYft67DDG IAYhbg9YoLdVkFJVnaZpA2aRRxEzwQQrRGtRVhLeZaHWmTR0dbSWFoE31KlyHdMuWlPZ HSmgP2DJeFQpyGHPRWx3huCZLhxa56Tw4XpOv840h7vICp47lhXzC2qqCqmFALE2H3XV HkwQ== X-Gm-Message-State: AOJu0YwUGPqIXnaLAE94G+Byzu6mzQvqtheBFjgharr1wzg5gKteLGRm KbmPTjpT7dW5uvzmqZgtfTNXLg== X-Google-Smtp-Source: AGHT+IH6Cg8HyarQaOAQwf1SPNguXE+Um7TXykdkOaoat4ioeBPWEFr32qCxi8hfH4f072Y/uiiTkA== X-Received: by 2002:a5d:47c4:0:b0:32f:c5ea:72ac with SMTP id o4-20020a5d47c4000000b0032fc5ea72acmr5258933wrc.46.1699255071432; Sun, 05 Nov 2023 23:17:51 -0800 (PST) Received: from [192.168.69.115] (176-131-220-199.abo.bbox.fr. [176.131.220.199]) by smtp.gmail.com with ESMTPSA id d18-20020adfa352000000b0032fb9c5aa24sm8066371wrb.93.2023.11.05.23.17.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Nov 2023 23:17:51 -0800 (PST) Message-ID: <6c39fdb9-1a77-3982-3ea5-00f58ca15e2c@linaro.org> Date: Mon, 6 Nov 2023 08:17:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic Content-Language: en-US To: Zhao Liu Cc: qemu-devel@nongnu.org, Eduardo Habkost , Xiaojuan Yang , "Michael S. Tsirkin" , qemu-ppc@nongnu.org, Aleksandar Rikalo , David Hildenbrand , qemu-s390x@nongnu.org, "Edgar E. Iglesias" , Jiaxun Yang , Song Gao , Paolo Bonzini , Stafford Horne , Alistair Francis , Yanan Wang , Max Filippov , Artyom Tarasenko , Marcel Apfelbaum , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Laurent Vivier , Aurelien Jarno , qemu-riscv@nongnu.org, Palmer Dabbelt , Yoshinori Sato , Bastian Koppelmann , Bin Meng , Daniel Henrique Barboza , Mark Cave-Ayland , Weiwei Li , Daniel Henrique Barboza , Nicholas Piggin , qemu-arm@nongnu.org, Liu Zhiwei , Marek Vasut , Laurent Vivier , Peter Maydell , Brian Cain , Thomas Huth , Chris Wulff , Sergio Lopez , Richard Henderson , Ilya Leoshkevich , Michael Rolnik References: <20231013140116.255-1-philmd@linaro.org> <20231013140116.255-3-philmd@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.137, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 20/10/23 09:14, Zhao Liu wrote: > Hi Philippe, > > On Fri, Oct 13, 2023 at 04:01:01PM +0200, Philippe Mathieu-Daudé wrote: >> Date: Fri, 13 Oct 2023 16:01:01 +0200 >> From: Philippe Mathieu-Daudé >> Subject: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic >> X-Mailer: git-send-email 2.41.0 >> >> "target/foo/cpu-qom.h" is supposed to be target agnostic >> (include-able by any target). Add such mention in the >> header. >> >> Signed-off-by: Philippe Mathieu-Daudé >> Reviewed-by: Richard Henderson >> --- >> target/arm/cpu-qom.h | 2 +- >> target/hppa/cpu-qom.h | 2 +- >> target/microblaze/cpu-qom.h | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) > > Why not mention this description for other qom-cpu.h in this series, > e.g., target/i386/cpu-qom.h. OK, will add a comment in each patch. > Otherwise, > > Reviewed-by: Zhao Liu Thanks!