qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH 05/10] hw/arm: Select VIRTIO_NET for virt machine
Date: Tue, 7 Feb 2023 19:19:19 +0100	[thread overview]
Message-ID: <6c5029a9-4832-fb7f-7dd4-eab81fe50a4b@redhat.com> (raw)
In-Reply-To: <20230206140809.26028-6-farosas@suse.de>

On 06/02/2023 15.08, Fabiano Rosas wrote:
> The 'virt' machine uses virtio-net-pci as a fallback when no other
> network driver has been selected via command line. Select VIRTIO_NET
> and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n
> (due to e.g. --without-default-devices):
> 
> $ ./qemu-system-aarch64 -M virt -accel tcg -cpu max
> qemu-system-aarch64: Unsupported NIC model: virtio-net-pci
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   hw/arm/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 2d157de9b8..8dcc08b7ec 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -31,6 +31,8 @@ config ARM_VIRT
>       select VIRTIO_MEM_SUPPORTED
>       select ACPI_CXL
>       select ACPI_HMAT
> +    select VIRTIO_PCI
> +    select VIRTIO_NET

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2023-02-07 18:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 14:07 [PATCH 00/10] Kconfig vs. default devices Fabiano Rosas
2023-02-06 14:08 ` [PATCH 01/10] vl.c: Do not add isa-parallel if it's not present Fabiano Rosas
2023-02-06 15:02   ` Philippe Mathieu-Daudé
2023-02-06 17:05     ` Fabiano Rosas
2023-02-06 14:08 ` [PATCH 02/10] hw/i386: Select E1000E for q35 Fabiano Rosas
2023-02-07 15:28   ` Thomas Huth
2023-02-06 14:08 ` [PATCH 03/10] hw/i386: Select VGA_PCI in Kconfig Fabiano Rosas
2023-02-07 15:47   ` Thomas Huth
2023-02-07 17:41     ` Fabiano Rosas
2023-02-06 14:08 ` [PATCH 04/10] hw/i386: Select E1000_PCI for i440fx Fabiano Rosas
2023-02-07 18:16   ` Thomas Huth
2023-02-06 14:08 ` [PATCH 05/10] hw/arm: Select VIRTIO_NET for virt machine Fabiano Rosas
2023-02-07 18:19   ` Thomas Huth [this message]
2023-02-06 14:08 ` [PATCH 06/10] hw/arm: Select VIRTIO_BLK " Fabiano Rosas
2023-02-07 18:26   ` Thomas Huth
2023-02-07 19:24     ` Fabiano Rosas
2023-02-06 14:08 ` [PATCH 07/10] hw/arm: Select XLNX_USB_SUBSYS for xlnx-zcu102 machine Fabiano Rosas
2023-02-06 14:21   ` Peter Maydell
2023-02-06 14:08 ` [PATCH 08/10] hw/arm: Select GICV3_TCG for sbsa-ref machine Fabiano Rosas
2023-02-06 14:21   ` Peter Maydell
2023-02-06 14:08 ` [PATCH 09/10] hw/arm: Select e1000e " Fabiano Rosas
2023-02-06 14:08 ` [PATCH 10/10] hw/arm: Select VGA_PCI " Fabiano Rosas
2023-02-06 14:22   ` Peter Maydell
2023-02-06 14:19 ` [PATCH 00/10] Kconfig vs. default devices Peter Maydell
2023-02-06 14:56   ` Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c5029a9-4832-fb7f-7dd4-eab81fe50a4b@redhat.com \
    --to=thuth@redhat.com \
    --cc=farosas@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).