From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] xio3130_downstream: typo fix
Date: Fri, 12 Jul 2019 19:10:08 +0200 [thread overview]
Message-ID: <6c600af7-6590-cdc0-20f3-677b37393693@redhat.com> (raw)
In-Reply-To: <20190711192512.31936-1-mst@redhat.com>
On 7/11/19 9:25 PM, Michael S. Tsirkin wrote:
> slt ctl/status are passed in incorrect order.
> Fix this up.
>
Fixes: Coverity (CID 1403007)
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/pci-bridge/xio3130_downstream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-bridge/xio3130_downstream.c b/hw/pci-bridge/xio3130_downstream.c
> index 899b0fd6c9..182e164f74 100644
> --- a/hw/pci-bridge/xio3130_downstream.c
> +++ b/hw/pci-bridge/xio3130_downstream.c
> @@ -43,7 +43,7 @@ static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address,
> {
> uint16_t slt_ctl, slt_sta;
>
> - pcie_cap_slot_get(d, &slt_sta, &slt_ctl);
> + pcie_cap_slot_get(d, &slt_ctl, &slt_sta);
> pci_bridge_write_config(d, address, val, len);
> pcie_cap_flr_write_config(d, address, val, len);
> pcie_cap_slot_write_config(d, slt_ctl, slt_sta, address, val, len);
>
prev parent reply other threads:[~2019-07-12 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 19:25 [Qemu-devel] [PATCH] xio3130_downstream: typo fix Michael S. Tsirkin
2019-07-12 7:55 ` Marcel Apfelbaum
2019-07-12 17:10 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c600af7-6590-cdc0-20f3-677b37393693@redhat.com \
--to=philmd@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).