From: Gustavo Romero <gustavo.romero@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, alex.bennee@linaro.org
Cc: peter.maydell@linaro.org
Subject: Re: [PATCH 1/2] gdbstub: Add Xfer:siginfo:read stub
Date: Thu, 7 Mar 2024 14:51:00 -0300 [thread overview]
Message-ID: <6c7a2014-737c-ed15-332b-0e4879ef5eed@linaro.org> (raw)
In-Reply-To: <aa702db8-9e72-4727-aac3-6824415ef29f@linaro.org>
On 3/4/24 2:18 PM, Richard Henderson wrote:
> On 3/3/24 09:26, Gustavo Romero wrote:
>> + /* Filter out si_type from si_code. See comment in siginfo_noswap(). */ > + tmp_siginfo = ts->sync_signal.info;
>> + tmp_siginfo.si_code = sextract32(tmp_siginfo.si_code, 0, 16);
>
>
> This is incorrect, as it only handles synchronous signals.
>
> In handle_pending_signal(), struct emulated_sigtable is passed, which has the correct siginfo (all of it, so no need for the adjustment). I think you need to pass that in to gdb_handlesig so that a copy can be made for later xfer.
Thanks, I'm sending v2 that fixes it.
Cheers,
Gustavo
prev parent reply other threads:[~2024-03-07 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 19:26 [PATCH 1/2] gdbstub: Add Xfer:siginfo:read stub Gustavo Romero
2024-03-03 19:26 ` [PATCH 2/2] tests/tcg: Add multiarch test for " Gustavo Romero
2024-03-04 17:21 ` Richard Henderson
2024-03-04 20:59 ` Gustavo Romero
2024-03-04 22:51 ` Richard Henderson
2024-03-07 17:50 ` Gustavo Romero
2024-03-07 19:31 ` Richard Henderson
2024-03-08 14:59 ` Gustavo Romero
2024-03-04 17:18 ` [PATCH 1/2] gdbstub: Add " Richard Henderson
2024-03-07 17:51 ` Gustavo Romero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c7a2014-737c-ed15-332b-0e4879ef5eed@linaro.org \
--to=gustavo.romero@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).