From: Thomas Huth <thuth@redhat.com>
To: Dima Stepanov <dimastep@yandex-team.ru>, qemu-devel@nongnu.org
Cc: stefanha@gmail.com, alxndr@bu.edu, yc-core@yandex-team.ru,
darren.kenny@oracle.com
Subject: Re: [PATCH v2 2/2] docs/fuzz: update make and run command lines
Date: Mon, 9 Nov 2020 13:20:48 +0100 [thread overview]
Message-ID: <6c8cb35d-84b4-4a8c-bff0-28446c0028d0@redhat.com> (raw)
In-Reply-To: <b7ae9363e9e32d0d608eab92cd48fe6f6db8a5ce.1604920905.git.dimastep@yandex-team.ru>
On 09/11/2020 12.25, Dima Stepanov wrote:
> After meson and some other build changes the qemu fuzz target should be
> build as:
> make qemu-fuzz-i386
> And also update the run path command line.
>
> Signed-off-by: Dima Stepanov <dimastep@yandex-team.ru>
> Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> docs/devel/fuzzing.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/devel/fuzzing.txt b/docs/devel/fuzzing.txt
> index 03585c1..590900c 100644
> --- a/docs/devel/fuzzing.txt
> +++ b/docs/devel/fuzzing.txt
> @@ -32,15 +32,15 @@ such as out-of-bounds accesses, use-after-frees, double-frees etc.
>
> Fuzz targets are built similarly to system/softmmu:
>
> - make i386-softmmu/fuzz
> + make qemu-fuzz-i386
>
> -This builds ./i386-softmmu/qemu-fuzz-i386
> +This builds ./build/qemu-fuzz-i386
>
> The first option to this command is: --fuzz-target=FUZZ_NAME
> To list all of the available fuzzers run qemu-fuzz-i386 with no arguments.
>
> For example:
> - ./i386-softmmu/qemu-fuzz-i386 --fuzz-target=virtio-scsi-fuzz
> + ./build/qemu-fuzz-i386 --fuzz-target=virtio-scsi-fuzz
>
> Internally, libfuzzer parses all arguments that do not begin with "--".
> Information about these is available by passing -help=1
This conflicts with Alexander's "docs/fuzz: update fuzzing documentation
post-meson" patch ... which one should be used? One is better for people who
do in-tree builds, the other is better for people who do out-of-tree builds
... I'll go with Alexander's version for now for my next pull-request, since
the text in this file says "/path/to/configure" which rather indicate
out-of-tree builds, but in the long run, it would maybe be good to add some
clarifying sentences here...
Thomas
next prev parent reply other threads:[~2020-11-09 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 11:25 [PATCH v2 0/2] fuzz: add virtio-blk fuzz target Dima Stepanov
2020-11-09 11:25 ` [PATCH v2 1/2] " Dima Stepanov
2020-11-09 12:24 ` Thomas Huth
2020-11-13 10:10 ` Dima Stepanov
2020-11-09 11:25 ` [PATCH v2 2/2] docs/fuzz: update make and run command lines Dima Stepanov
2020-11-09 12:20 ` Thomas Huth [this message]
2020-11-09 14:45 ` Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c8cb35d-84b4-4a8c-bff0-28446c0028d0@redhat.com \
--to=thuth@redhat.com \
--cc=alxndr@bu.edu \
--cc=darren.kenny@oracle.com \
--cc=dimastep@yandex-team.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).