From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Alex Williamson <alex.williamson@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation
Date: Mon, 30 Apr 2018 15:08:44 +0200 [thread overview]
Message-ID: <6c90618c-ec1b-7a73-5a76-b98fe5df589a@redhat.com> (raw)
In-Reply-To: <CAFEAcA-frhSPZePsQJy8DJTpFX0iFw52ND_VK8Z=hGz-v1A_jA@mail.gmail.com>
On 30/04/2018 14:57, Peter Maydell wrote:
> On 30 April 2018 at 13:54, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 30/04/2018 14:24, Peter Maydell wrote:
>>> - /* Set this up to provide customized IOMMU replay function */
>>> + /* Set this up to provide customized IOMMU replay function.
>>> + * Optional method.
>>> + */
>>> void (*replay)(IOMMUMemoryRegion *iommu, IOMMUNotifier *notifier);
>>
>> replay is needed if you want to support IOMMU notifiers. After
>> memory_region_register_iommu_notifier you're only notified about future
>> changes to the mappings; memory_region_iommu_replay calls the replay
>> method so that the IOMMUNotifier is called for each existing mapping.
>
> Is it then unrelated to record-and-replay ? That's what I guessed
> it was for... Also, some IOMMUs (eg spapr_iommu.c) seem to support
> notifiers but don't implement it.
Yes, it's completely unrelated. I have no idea why spapr_iommu.c
doesn't need it, so I am CCing the sPAPR and VFIO experts...
Paolo
next prev parent reply other threads:[~2018-04-30 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 12:24 [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation Peter Maydell
2018-04-30 12:54 ` Paolo Bonzini
2018-04-30 12:57 ` Peter Maydell
2018-04-30 13:08 ` Paolo Bonzini [this message]
2018-04-30 13:35 ` Peter Maydell
2018-04-30 14:28 ` Alex Williamson
2018-05-01 1:01 ` David Gibson
2018-04-30 13:34 ` Peter Maydell
2018-04-30 15:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c90618c-ec1b-7a73-5a76-b98fe5df589a@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).