From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27F48C433DB for ; Mon, 15 Mar 2021 08:12:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE77564E86 for ; Mon, 15 Mar 2021 08:12:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE77564E86 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLiKw-00008u-RO for qemu-devel@archiver.kernel.org; Mon, 15 Mar 2021 04:12:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLiGo-0003vV-6t for qemu-devel@nongnu.org; Mon, 15 Mar 2021 04:08:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23290) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lLiGl-0001eM-Co for qemu-devel@nongnu.org; Mon, 15 Mar 2021 04:08:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615795686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aiOv4tz58fNufgJfrV+BhOuttcqCTy6OhPO7j+L2cl4=; b=PtMC9xykM4A/VAJ1/ajFasGSD4wRGasM7150xxI68YP1VrDnpBV5OKqqSqWSWMZZpn3QiI hHrw8wQz6qaGjl0Xl4fJvUoVK0nV6g1TGEo0UvH3cIfS9U4Y5cDf76/1ZW3+K9A8pvmrRi cdsfz9IOovDTjOUos5wY0QotcMfVJiE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-sec0lNSrNIeeSdiDzf6Qyg-1; Mon, 15 Mar 2021 04:08:04 -0400 X-MC-Unique: sec0lNSrNIeeSdiDzf6Qyg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C798C100C664 for ; Mon, 15 Mar 2021 08:08:03 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-72.ams2.redhat.com [10.36.112.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED604610AF; Mon, 15 Mar 2021 08:08:02 +0000 (UTC) Subject: Re: [PATCH v2] Add missing initialization for g_autofree variables To: mrezanin@redhat.com, qemu-devel@nongnu.org References: <20210315080032.152210-1-mrezanin@redhat.com> From: Thomas Huth Message-ID: <6ca4cc62-2313-e2db-1ad1-e7b9c4dfb829@redhat.com> Date: Mon, 15 Mar 2021 09:08:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210315080032.152210-1-mrezanin@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15/03/2021 09.00, mrezanin@redhat.com wrote: > From: Miroslav Rezanina > > When declaring g_autofree variable without inicialization, compiler > will raise "may be used uninitialized in this function" warning due > to automatic free handling. > > This is mentioned in docs/devel/style.rst (quote from section > "Automatic memory deallocation"): > > * Variables declared with g_auto* MUST always be initialized, > otherwise the cleanup function will use uninitialized stack memory > > Add inicialization to NULL for these declaration to prevent this > warning. > > Signed-off-by: Miroslav Rezanina > > --- > * From v1: > -- Removed fixes in hw/remote/memory.c and hw/remote/proxy.c > fixed by patch sent by Zenghui Yu (multi-process: Initialize > variables declared with g_auto*) > --- > hw/s390x/s390-pci-vfio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c > index ead4f222d5..0ee7dc21f2 100644 > --- a/hw/s390x/s390-pci-vfio.c > +++ b/hw/s390x/s390-pci-vfio.c > @@ -29,7 +29,7 @@ > */ > bool s390_pci_update_dma_avail(int fd, unsigned int *avail) > { > - g_autofree struct vfio_iommu_type1_info *info; > + g_autofree struct vfio_iommu_type1_info *info = NULL; > uint32_t argsz; > > assert(avail); I'd maybe rather rework the functions like this: diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c index ead4f222d5..1fe71fd93f 100644 --- a/hw/s390x/s390-pci-vfio.c +++ b/hw/s390x/s390-pci-vfio.c @@ -29,14 +29,11 @@ */ bool s390_pci_update_dma_avail(int fd, unsigned int *avail) { - g_autofree struct vfio_iommu_type1_info *info; - uint32_t argsz; + uint32_t argsz = sizeof(struct vfio_iommu_type1_info); + g_autofree struct vfio_iommu_type1_info *info = g_malloc0(argsz); assert(avail); - argsz = sizeof(struct vfio_iommu_type1_info); - info = g_malloc0(argsz); - /* * If the specified argsz is not large enough to contain all capabilities * it will be updated upon return from the ioctl. Retry until we have > @@ -230,7 +230,7 @@ static void s390_pci_read_pfip(S390PCIBusDevice *pbdev, > */ > void s390_pci_get_clp_info(S390PCIBusDevice *pbdev) > { > - g_autofree struct vfio_device_info *info; > + g_autofree struct vfio_device_info *info = NULL; > VFIOPCIDevice *vfio_pci; > uint32_t argsz; > int fd; > Anyway, Reviewed-by: Thomas Huth