From: Richard Henderson <richard.henderson@linaro.org>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, alex.bennee@linaro.org, peterx@redhat.com,
david@redhat.com
Subject: Re: [PATCH 1/4] softmmu: fix watchpoint processing in icount mode
Date: Thu, 28 Oct 2021 12:09:50 -0700 [thread overview]
Message-ID: <6ca64e11-611e-4620-ad54-4cbab8e6bd2e@linaro.org> (raw)
In-Reply-To: <163542168516.2127597.8781375223437124644.stgit@pasha-ThinkPad-X280>
On 10/28/21 4:48 AM, Pavel Dovgalyuk wrote:
> Watchpoint processing code restores vCPU state twice:
> in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_state.
> Normally it does not affect anything, but in icount mode instruction
> counter is incremented twice and becomes incorrect.
> This patch eliminates unneeded CPU state restore.
>
> Signed-off-by: Pavel Dovgalyuk<Pavel.Dovgalyuk@ispras.ru>
> Reviewed-by: David Hildenbrand<david@redhat.com>
> ---
> softmmu/physmem.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-10-28 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 11:47 [PATCH 0/4] Some watchpoint-related patches Pavel Dovgalyuk
2021-10-28 11:48 ` [PATCH 1/4] softmmu: fix watchpoint processing in icount mode Pavel Dovgalyuk
2021-10-28 19:09 ` Richard Henderson [this message]
2021-10-28 11:48 ` [PATCH 2/4] softmmu: remove useless condition in watchpoint check Pavel Dovgalyuk
2021-10-28 19:10 ` Richard Henderson
2021-10-28 11:48 ` [PATCH 3/4] softmmu: fix for "after access" watchpoints Pavel Dovgalyuk
2021-10-28 19:13 ` Richard Henderson
2021-10-28 11:48 ` [PATCH 4/4] icount: preserve cflags when custom tb is about to execute Pavel Dovgalyuk
2021-10-28 19:26 ` Richard Henderson
2021-11-03 8:44 ` Pavel Dovgalyuk
2021-11-11 9:56 ` Pavel Dovgalyuk
2021-10-28 19:29 ` [PATCH 0/4] Some watchpoint-related patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ca64e11-611e-4620-ad54-4cbab8e6bd2e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=david@redhat.com \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).