From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb
Date: Thu, 9 Apr 2020 21:29:47 +0200 [thread overview]
Message-ID: <6cd605a3-1369-9714-321e-5d1c6fcbfc39@redhat.com> (raw)
In-Reply-To: <20200409180130.GA10061@xz-x1>
On 4/9/20 8:01 PM, Peter Xu wrote:
> Hi, Phil,
>
> On Thu, Apr 09, 2020 at 07:21:04PM +0200, Philippe Mathieu-Daudé wrote:
>> On 4/9/20 6:49 PM, Peter Xu wrote:
>>> We should only pass in gdb_get_reg16() with the GByteArray* object
>>> itself, no need to shift. Without this patch, gdb remote attach will
>>> crash QEMU.
>>
>> You are correct.
>>
>> Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
>
> Oh I forgot to paste the fix line. However, is it b7b8756a9c
> ("target/i386: use gdb_get_reg helpers", 2020-03-17) instead?
b7b8756a9c is correct, at that time the codebase was using the correct
API. the next commit updated the API but missed to update the lines you
are fixed. So I think "fixes a010bdbe719" is correct.
>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks!
>
>>
>> Same problem in m68k_fpu_gdb_get_reg().
>>
>> TODO for 5.1, rename mem_buf -> array.
>
next prev parent reply other threads:[~2020-04-09 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 16:49 [PATCH 0/2] gdbstub: Unbreak i386 with gdb remote Peter Xu
2020-04-09 16:49 ` [PATCH 1/2] gdbstub: Assert len read from each register Peter Xu
2020-04-09 17:51 ` Philippe Mathieu-Daudé
2020-04-09 18:12 ` Peter Xu
2020-04-09 16:49 ` [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb Peter Xu
2020-04-09 17:21 ` Philippe Mathieu-Daudé
2020-04-09 18:01 ` Peter Xu
2020-04-09 19:29 ` Philippe Mathieu-Daudé [this message]
2020-04-09 20:36 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cd605a3-1369-9714-321e-5d1c6fcbfc39@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).