From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>,
qemu-trivial@nongnu.org, Hannes Reinecke <hare@suse.com>,
qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] hw/scsi/megasas: Simplify using the ldst API
Date: Sat, 18 Dec 2021 12:15:39 +0100 [thread overview]
Message-ID: <6cdce8f1-859c-9504-3158-cea7e30bdda9@redhat.com> (raw)
In-Reply-To: <32549938-46c1-94d0-dc3a-3a722d4fc31d@linaro.org>
On 12/18/21 01:36, Richard Henderson wrote:
> On 12/17/21 3:15 PM, Philippe Mathieu-Daudé wrote:
>> - cdb[3] = (len >> 8) & 0xff;
>> - cdb[4] = (len & 0xff);
>> + stw_be_p(&cdb[2], len);
>
> Wrong offset. Otherwise,
>_<
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Thank you.
prev parent reply other threads:[~2021-12-18 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 23:15 [PATCH] hw/scsi/megasas: Simplify using the ldst API Philippe Mathieu-Daudé
2021-12-18 0:36 ` Richard Henderson
2021-12-18 11:15 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cdce8f1-859c-9504-3158-cea7e30bdda9@redhat.com \
--to=philmd@redhat.com \
--cc=fam@euphon.net \
--cc=hare@suse.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).