From: Paolo Bonzini <pbonzini@redhat.com>
To: "Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global <driver>.<property>=<val> option
Date: Tue, 23 Nov 2021 14:17:54 +0100 [thread overview]
Message-ID: <6ce18451-892b-54cb-a0d3-5c7fd471ea98@redhat.com> (raw)
In-Reply-To: <87ilwkjm63.fsf@dusky.pond.sub.org>
On 11/22/21 15:32, Markus Armbruster wrote:
>> qemu-system-x86_64: warning: global cfi.pflash01.secure has invalid class name
>>
>> what's going on here ?
> Off-the-cuff guess: cfi.pflash01.secure=on gets parsed as
>
> driver=cfi
> property=pflash01.secure
> value=on
>
> Once again our "anything goes" attitude to naming wastes us time and
> thus money.
I'd blame more the sscanf parsing. Anyway, -global
driver=...,property=...,value=... works just fine in all cases, it's
just more verbose---and it might even be easier to use for Libvirt, if
it can use its usual QemuOpts-building facilities.
Anyhow, this patch breaks existing clients, as pointed out by Markus.
Paolo
> In contrast, QAPI restricts names to "only ASCII letters, digits,
> hyphen, and underscore" (see docs/devel/qapi-code-gen.rst section Naming
> rules and reserved names).
prev parent reply other threads:[~2021-11-23 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 18:26 [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global <driver>.<property>=<val> option Philippe Mathieu-Daudé
2021-11-19 18:46 ` BALATON Zoltan
2021-11-19 19:07 ` Philippe Mathieu-Daudé
2021-11-20 6:53 ` Markus Armbruster
2021-11-22 13:21 ` Daniel P. Berrangé
2021-11-22 14:32 ` Markus Armbruster
2021-11-23 13:17 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ce18451-892b-54cb-a0d3-5c7fd471ea98@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).