From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A455C432C0 for ; Mon, 18 Nov 2019 08:02:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 096CC2071C for ; Mon, 18 Nov 2019 08:02:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 096CC2071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWbzn-0000Fl-56 for qemu-devel@archiver.kernel.org; Mon, 18 Nov 2019 03:02:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47201) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWbz2-0007zC-7t for qemu-devel@nongnu.org; Mon, 18 Nov 2019 03:02:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWbz1-0007M4-1j for qemu-devel@nongnu.org; Mon, 18 Nov 2019 03:02:03 -0500 Received: from 6.mo177.mail-out.ovh.net ([46.105.51.249]:35740) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iWbyx-0007Bd-MV for qemu-devel@nongnu.org; Mon, 18 Nov 2019 03:02:01 -0500 Received: from player763.ha.ovh.net (unknown [10.109.160.93]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id 9538210E746 for ; Mon, 18 Nov 2019 09:01:53 +0100 (CET) Received: from kaod.org (lfbn-1-2229-223.w90-76.abo.wanadoo.fr [90.76.50.223]) (Authenticated sender: clg@kaod.org) by player763.ha.ovh.net (Postfix) with ESMTPSA id 1AF27C361097; Mon, 18 Nov 2019 08:01:44 +0000 (UTC) Subject: Re: [QEMU-DEVEL][PATCH] gpio: fix memory leak in aspeed_gpio_init() To: pannengyuan@huawei.com, peter.maydell@linaro.org, andrew@aj.id.au, joel@jms.id.au References: <1574041065-34936-1-git-send-email-pannengyuan@huawei.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <6cfb4721-d2f7-6876-83a8-2e4bf82b8c84@kaod.org> Date: Mon, 18 Nov 2019 09:01:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <1574041065-34936-1-git-send-email-pannengyuan@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Ovh-Tracer-Id: 5760385401363532776 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudeggedgudduiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjqdffgfeufgfipdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepuffvfhfhkffffgggjggtgfesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucfkpheptddrtddrtddrtddpledtrdejiedrhedtrddvvdefnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejieefrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.51.249 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, kenny.zhangjun@huawei.com, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 18/11/2019 02:37, pannengyuan@huawei.com wrote: > From: PanNengyuan >=20 > Address Sanitizer shows memory leak in hw/gpio/aspeed_gpio.c:875 >=20 > Reported-by: Euler Robot > Signed-off-by: PanNengyuan Reviewed-by: C=C3=A9dric Le Goater =20 I will add this patch the series I am building for 5.0. Thanks, C. > --- > hw/gpio/aspeed_gpio.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c > index 7acc5fa..41e11ea 100644 > --- a/hw/gpio/aspeed_gpio.c > +++ b/hw/gpio/aspeed_gpio.c > @@ -876,6 +876,7 @@ static void aspeed_gpio_init(Object *obj) > pin_idx % GPIOS_PER_GROUP); > object_property_add(obj, name, "bool", aspeed_gpio_get_pin, > aspeed_gpio_set_pin, NULL, NULL, NULL); > + g_free(name); > } > } > =20 >=20