qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Shreya Shrivastava" <pink89@sigaint.org>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com
Subject: [Qemu-devel] [PATCH 3/4] Add error checking for event_notifier_init.
Date: Sun, 16 Oct 2016 00:50:58 -0000	[thread overview]
Message-ID: <6d027264208d6f6013e3c8248405a968.webmail@localhost> (raw)

Add checks for negative return value to uses of event_notifier_init.
Signed-off-by: Shreya Shrivastava <pink89@sigaint.org>

---
 tests/test-aio.c | 59
++++++++++++++++++++++++++++----------------------------
 1 file changed, 30 insertions(+), 29 deletions(-)

diff --git a/tests/test-aio.c b/tests/test-aio.c
index 03aa846..49b99f6 100644
--- a/tests/test-aio.c
+++ b/tests/test-aio.c
@@ -137,8 +137,8 @@ static void test_acquire(void)
     AcquireTestData data;

     /* Dummy event notifier ensures aio_poll() will block */
-    event_notifier_init(&notifier, false);
-    set_event_notifier(ctx, &notifier, dummy_notifier_read);
+    if (event_notifier_init(&notifier, false))
+        set_event_notifier(ctx, &notifier, dummy_notifier_read);
     g_assert(!aio_poll(ctx, false)); /* consume aio_notify() */

     qemu_mutex_init(&data.start_lock);
@@ -314,8 +314,8 @@ static void test_bh_flush(void)
 static void test_set_event_notifier(void)
 {
     EventNotifierTestData data = { .n = 0, .active = 0 };
-    event_notifier_init(&data.e, false);
-    set_event_notifier(ctx, &data.e, event_ready_cb);
+    if (event_notifier_init(&data.e, false))
+        set_event_notifier(ctx, &data.e, event_ready_cb);
     g_assert(!aio_poll(ctx, false));
     g_assert_cmpint(data.n, ==, 0);

@@ -328,8 +328,8 @@ static void test_set_event_notifier(void)
 static void test_wait_event_notifier(void)
 {
     EventNotifierTestData data = { .n = 0, .active = 1 };
-    event_notifier_init(&data.e, false);
-    set_event_notifier(ctx, &data.e, event_ready_cb);
+    if (event_notifier_init(&data.e, false))
+        set_event_notifier(ctx, &data.e, event_ready_cb);
     while (aio_poll(ctx, false));
     g_assert_cmpint(data.n, ==, 0);
     g_assert_cmpint(data.active, ==, 1);
@@ -353,8 +353,8 @@ static void test_wait_event_notifier(void)
 static void test_flush_event_notifier(void)
 {
     EventNotifierTestData data = { .n = 0, .active = 10, .auto_set = true };
-    event_notifier_init(&data.e, false);
-    set_event_notifier(ctx, &data.e, event_ready_cb);
+    if (event_notifier_init(&data.e, false))
+        set_event_notifier(ctx, &data.e, event_ready_cb);
     while (aio_poll(ctx, false));
     g_assert_cmpint(data.n, ==, 0);
     g_assert_cmpint(data.active, ==, 10);
@@ -381,9 +381,10 @@ static void test_aio_external_client(void)

     for (i = 1; i < 3; i++) {
         EventNotifierTestData data = { .n = 0, .active = 10, .auto_set =
true };
-        event_notifier_init(&data.e, false);
-        aio_set_event_notifier(ctx, &data.e, true, event_ready_cb);
-        event_notifier_set(&data.e);
+        if (event_notifier_init(&data.e, false) {
+            aio_set_event_notifier(ctx, &data.e, true, event_ready_cb);
+            event_notifier_set(&data.e);
+            }
         for (j = 0; j < i; j++) {
             aio_disable_external(ctx);
         }
@@ -404,8 +405,8 @@ static void test_wait_event_notifier_noflush(void)
     EventNotifierTestData data = { .n = 0 };
     EventNotifierTestData dummy = { .n = 0, .active = 1 };

-    event_notifier_init(&data.e, false);
-    set_event_notifier(ctx, &data.e, event_ready_cb);
+    if (event_notifier_init(&data.e, false))
+        set_event_notifier(ctx, &data.e, event_ready_cb);

     g_assert(!aio_poll(ctx, false));
     g_assert_cmpint(data.n, ==, 0);
@@ -417,8 +418,8 @@ static void test_wait_event_notifier_noflush(void)
     data.n = 0;

     /* An active event notifier forces aio_poll to look at
EventNotifiers.  */
-    event_notifier_init(&dummy.e, false);
-    set_event_notifier(ctx, &dummy.e, event_ready_cb);
+    if (event_notifier_init(&dummy.e, false)
+        set_event_notifier(ctx, &dummy.e, event_ready_cb);

     event_notifier_set(&data.e);
     g_assert(aio_poll(ctx, false));
@@ -458,8 +459,8 @@ static void test_timer_schedule(void)
     /* aio_poll will not block to wait for timers to complete unless it has
      * an fd to wait on. Fixing this breaks other tests. So create a
dummy one.
      */
-    event_notifier_init(&e, false);
-    set_event_notifier(ctx, &e, dummy_io_handler_read);
+    if (event_notifier_init(&e, false))
+        set_event_notifier(ctx, &e, dummy_io_handler_read);
     aio_poll(ctx, false);

     aio_timer_init(ctx, &data.timer, data.clock_type,
@@ -668,8 +669,8 @@ static void test_source_bh_flush(void)
 static void test_source_set_event_notifier(void)
 {
     EventNotifierTestData data = { .n = 0, .active = 0 };
-    event_notifier_init(&data.e, false);
-    set_event_notifier(ctx, &data.e, event_ready_cb);
+    if (event_notifier_init(&data.e, false)
+        set_event_notifier(ctx, &data.e, event_ready_cb);
     while (g_main_context_iteration(NULL, false));
     g_assert_cmpint(data.n, ==, 0);

@@ -682,8 +683,8 @@ static void test_source_set_event_notifier(void)
 static void test_source_wait_event_notifier(void)
 {
     EventNotifierTestData data = { .n = 0, .active = 1 };
-    event_notifier_init(&data.e, false);
-    set_event_notifier(ctx, &data.e, event_ready_cb);
+    if (event_notifier_init(&data.e, false))
+        set_event_notifier(ctx, &data.e, event_ready_cb);
     while (g_main_context_iteration(NULL, false));
     g_assert_cmpint(data.n, ==, 0);
     g_assert_cmpint(data.active, ==, 1);
@@ -707,8 +708,8 @@ static void test_source_wait_event_notifier(void)
 static void test_source_flush_event_notifier(void)
 {
     EventNotifierTestData data = { .n = 0, .active = 10, .auto_set = true };
-    event_notifier_init(&data.e, false);
-    set_event_notifier(ctx, &data.e, event_ready_cb);
+    if (event_notifier_init(&data.e, false))
+        set_event_notifier(ctx, &data.e, event_ready_cb);
     while (g_main_context_iteration(NULL, false));
     g_assert_cmpint(data.n, ==, 0);
     g_assert_cmpint(data.active, ==, 10);
@@ -734,8 +735,8 @@ static void test_source_wait_event_notifier_noflush(void)
     EventNotifierTestData data = { .n = 0 };
     EventNotifierTestData dummy = { .n = 0, .active = 1 };

-    event_notifier_init(&data.e, false);
-    set_event_notifier(ctx, &data.e, event_ready_cb);
+    if (event_notifier_init(&data.e, false))
+        set_event_notifier(ctx, &data.e, event_ready_cb);

     while (g_main_context_iteration(NULL, false));
     g_assert_cmpint(data.n, ==, 0);
@@ -747,8 +748,8 @@ static void test_source_wait_event_notifier_noflush(void)
     data.n = 0;

     /* An active event notifier forces aio_poll to look at
EventNotifiers.  */
-    event_notifier_init(&dummy.e, false);
-    set_event_notifier(ctx, &dummy.e, event_ready_cb);
+    if (event_notifier_init(&dummy.e, false))
+        set_event_notifier(ctx, &dummy.e, event_ready_cb);

     event_notifier_set(&data.e);
     g_assert(g_main_context_iteration(NULL, false));
@@ -789,8 +790,8 @@ static void test_source_timer_schedule(void)
     /* aio_poll will not block to wait for timers to complete unless it has
      * an fd to wait on. Fixing this breaks other tests. So create a
dummy one.
      */
-    event_notifier_init(&e, false);
-    set_event_notifier(ctx, &e, dummy_io_handler_read);
+    if (event_notifier_init(&e, false))
+        set_event_notifier(ctx, &e, dummy_io_handler_read);
     do {} while (g_main_context_iteration(NULL, false));

     aio_timer_init(ctx, &data.timer, data.clock_type,
-- 
1.9.1

             reply	other threads:[~2016-10-16  0:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-16  0:50 Shreya Shrivastava [this message]
2016-10-16 16:58 ` [Qemu-devel] [PATCH 3/4] Add error checking for event_notifier_init Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d027264208d6f6013e3c8248405a968.webmail@localhost \
    --to=pink89@sigaint.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).