Re: [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

[Richard Henderson <richard.henderson@linaro.org>]

On 09/19/2017 04:18 PM, Eric Blake wrote:
> On 09/19/2017 04:10 PM, Laurent Vivier wrote:
>> We already have const_float16(), const_float32() and const_float64(),
>> so rename make_floatx80_init() and make_float128_init() as
> 
> s/as/to now be/
> 
>> const_floatx80() and const_float128().
> 
> s/\./, for consistency./
> 
>>
>> Redefine make_float16(), make_float32() and make_float64() as
> 
> s/as/to be like/
> 
>> make_floatx80() and make_float128() using a cast.
> 
> s/ using a cast/, by using a compound literal/

I was about to make the same quibble.

> I almost wonder if splitting this patch into two parts makes more sense
> (one for the renaming of make_float[x80,128]_init, the other for the
> rewriting of make_float[16,32,64] from gcc extension to compound literal).

I think the patch is fine as-is.

Fix the patch description and I'll give it

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~