From: Thomas Huth <thuth@redhat.com>
To: "Eric Blake" <eblake@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: Qemu-block <qemu-block@nongnu.org>, Peter Lieven <pl@kamp.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode
Date: Mon, 14 Jan 2019 16:37:44 +0100 [thread overview]
Message-ID: <6d155740-66a0-3879-4e05-8a6fb50b02b8@redhat.com> (raw)
In-Reply-To: <150611f1-774a-a0c9-9e22-756d8e87b7ca@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
On 2019-01-14 16:23, Thomas Huth wrote:
> On 2019-01-14 16:02, Eric Blake wrote:
>> On 1/14/19 8:53 AM, Thomas Huth wrote:
[...]
>>> The patch is only changing libiscsi_cflags, so it's not affecting the
>>> entire project, but just the files that use libiscsi.
>>
>> Even so, limiting the damage to just the wrapper file that includes the
>> problematic header rather than changing the command line for the entire
>> compilation of those files that use libiscsi is even more precise.
>
> Then our only option is "#define inline /* nothing */", as far as I can
> see...
Or this one, which seems to be a better idea to me:
#define inline __attribute__((gnu_inline))
gnu_inline should give the same behavior like the "inline" keywords in
gnu89 mode.
Thomas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2019-01-14 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 13:46 [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode Thomas Huth
2019-01-14 13:52 ` Peter Maydell
2019-01-14 14:31 ` Daniel P. Berrangé
2019-01-14 14:38 ` Thomas Huth
2019-01-14 14:50 ` Eric Blake
2019-01-14 14:53 ` Thomas Huth
2019-01-14 15:02 ` Eric Blake
2019-01-14 15:23 ` Thomas Huth
2019-01-14 15:37 ` Thomas Huth [this message]
2019-01-14 15:05 ` Daniel P. Berrangé
2019-01-14 14:31 ` Philippe Mathieu-Daudé
2019-01-14 14:36 ` Thomas Huth
2019-01-14 15:15 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d155740-66a0-3879-4e05-8a6fb50b02b8@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).