From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Subject: Re: [PATCH v2 00/13] Misc ppc/mac machines clean up
Date: Mon, 26 Sep 2022 18:40:02 -0300 [thread overview]
Message-ID: <6d15737b-bcfd-9fdf-2072-d906acf05a9c@gmail.com> (raw)
In-Reply-To: <cover.1664108862.git.balaton@eik.bme.hu>
Mark,
It seems that you're usually push mac changes via a qemu-macppc PR (git log
says that the last one was Jan 2021), so feel free to keep doing so.
If it's convenient for you I can pick them via ppc-next as well. Just let me
know.
Thanks,
Daniel
On 9/25/22 09:38, BALATON Zoltan wrote:
> This series includes some clean ups to mac_newworld and mac_oldworld
> to make them a bit simpler and more readable, It also removes the
> shared mac.h file that turns out was more of a random collection of
> unrelated things. Getting rid of this mac.h improves the locality of
> device models and reduces unnecessary interdependency.
>
> v2: Split some patches and add a few more I've noticed now and address
> review comments
>
> BALATON Zoltan (13):
> mac_newworld: Drop some variables
> mac_oldworld: Drop some more variables
> mac_{old|new}world: Set tbfreq at declaration
> mac_{old|new}world: Avoid else branch by setting default value
> mac_oldworld: Do not open code sysbus_mmio_map()
> mac_newworld: Simplify creation of Uninorth devices
> mac_{old|new}world: Reduce number of QOM casts
> hw/ppc/mac.h: Move newworld specific parts out from shared header
> hw/ppc/mac.h: Move macio specific parts out from shared header
> hw/ppc/mac.h: Move grackle-pcihost declaration out from shared header
> hw/ppc/mac.h: Move PROM and KERNEL defines to board code
> hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h
> mac_nvram: Use NVRAM_SIZE constant
>
> MAINTAINERS | 1 +
> hw/ide/macio.c | 1 -
> hw/intc/heathrow_pic.c | 1 -
> hw/intc/openpic.c | 1 -
> hw/misc/macio/cuda.c | 1 -
> hw/misc/macio/gpio.c | 1 -
> hw/misc/macio/macio.c | 8 +-
> hw/misc/macio/pmu.c | 1 -
> hw/nvram/mac_nvram.c | 2 +-
> hw/pci-host/grackle.c | 2 +-
> hw/pci-host/uninorth.c | 1 -
> hw/ppc/mac.h | 105 ----------------
> hw/ppc/mac_newworld.c | 223 ++++++++++++++++------------------
> hw/ppc/mac_oldworld.c | 113 +++++++----------
> include/hw/misc/macio/macio.h | 23 +++-
> include/hw/nvram/mac_nvram.h | 51 ++++++++
> 16 files changed, 230 insertions(+), 305 deletions(-)
> delete mode 100644 hw/ppc/mac.h
> create mode 100644 include/hw/nvram/mac_nvram.h
>
next prev parent reply other threads:[~2022-09-26 21:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 12:38 [PATCH v2 00/13] Misc ppc/mac machines clean up BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 01/13] mac_newworld: Drop some variables BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 02/13] mac_oldworld: Drop some more variables BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 03/13] mac_{old|new}world: Set tbfreq at declaration BALATON Zoltan
2022-09-29 7:09 ` Mark Cave-Ayland
2022-09-25 12:38 ` [PATCH v2 04/13] mac_{old|new}world: Avoid else branch by setting default value BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 05/13] mac_oldworld: Do not open code sysbus_mmio_map() BALATON Zoltan
2022-09-29 7:28 ` Mark Cave-Ayland
2022-09-29 11:32 ` BALATON Zoltan
2022-10-03 7:54 ` Mark Cave-Ayland
2022-10-03 20:18 ` BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 06/13] mac_newworld: Simplify creation of Uninorth devices BALATON Zoltan
2022-09-29 7:39 ` Mark Cave-Ayland
2022-10-03 14:05 ` Philippe Mathieu-Daudé via
2022-10-04 6:39 ` Markus Armbruster
2022-10-04 8:00 ` Daniel P. Berrangé
2022-09-25 12:38 ` [PATCH v2 07/13] mac_{old|new}world: Reduce number of QOM casts BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 08/13] hw/ppc/mac.h: Move newworld specific parts out from shared header BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 09/13] hw/ppc/mac.h: Move macio " BALATON Zoltan
2022-09-29 7:43 ` Mark Cave-Ayland
2022-09-25 12:38 ` [PATCH v2 10/13] hw/ppc/mac.h: Move grackle-pcihost declaration " BALATON Zoltan
2022-09-29 7:44 ` Mark Cave-Ayland
2022-09-29 11:42 ` BALATON Zoltan
2022-10-03 7:57 ` Mark Cave-Ayland
2022-09-25 12:38 ` [PATCH v2 11/13] hw/ppc/mac.h: Move PROM and KERNEL defines to board code BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 12/13] hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h BALATON Zoltan
2022-09-25 12:38 ` [PATCH v2 13/13] mac_nvram: Use NVRAM_SIZE constant BALATON Zoltan
2022-09-29 7:45 ` Mark Cave-Ayland
2022-09-26 21:40 ` Daniel Henrique Barboza [this message]
2022-10-03 8:11 ` [PATCH v2 00/13] Misc ppc/mac machines clean up Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d15737b-bcfd-9fdf-2072-d906acf05a9c@gmail.com \
--to=danielhb413@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).