Re: [PATCH v3 00/10] Introduce new acpi/smbios avocado tests using biosbits

[Thomas Huth <thuth@redhat.com>]

On 10/10/2022 11.13, Ani Sinha wrote:
> On Mon, Oct 10, 2022 at 2:26 PM Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 10/10/2022 10.13, Ani Sinha wrote:
>>> On Mon, Oct 10, 2022 at 1:24 PM Ani Sinha <ani@anisinha.ca> wrote:
>>>>
>>>> Please see the README file added in patch 10 for more details.
>>>> Sample runs are as follows:
>>>>
>>>> $ ./tests/venv/bin/avocado run -t acpi tests/avocado --tap -
>>>> ERROR:  Missing parentheses in call to 'print'. Did you mean print(...)? (smbios.py, line 92)
>>>> ERROR:  Missing parentheses in call to 'print'. Did you mean print(...)? (smilatency.py, line 47)
>>>> ERROR:  Missing parentheses in call to 'print'. Did you mean print(...)? (testacpi.py, line 158)
>>>
>>> None of the above files are avocado tests or avocado related python
>>> scripts. They are run from within bits in a python 2.7 environment. I
>>> could not find a mechanism to exclude a directory from avocado tests.
>>> I also do not think making those scripts python 3 compliant is a good
>>> use of my time since upgrading bits to use python 3 would be a major
>>> task unrelated to QEMU testing.
>>
>> Maybe you could at least switch those three lines to use the new print()
>> syntax
> 
> There are lots of print statements in those three files using old
> syntax. It's only complaining about the first one.
> 
> to silence at least these ugly errors? ... Python 2.7 should cope

Yeah, but everybody who wants to run the QEMU avocado tests will wonder 
about those ERROR messages! So I don't think that this is acceptable in the 
current shape. Either fix the print lines, or move it to another directory.

  Thomas