From: Gavin Shan <gshan@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Aldy Hernandez <aldyh@redhat.com>, Thomas Huth <thuth@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>,
qemu-arm <qemu-arm@nongnu.org>, Shan Gavin <shan.gavin@gmail.com>,
Philippe Mathieu Daude <philmd@redhat.com>
Subject: Re: [PATCH] configure: Improve alias attribute check
Date: Tue, 23 Mar 2021 14:13:08 +1100 [thread overview]
Message-ID: <6d1973a3-159a-6c1b-2767-29dcb91a6562@redhat.com> (raw)
In-Reply-To: <696de0d3-3b35-6c9a-1242-3761e6d6ec83@linaro.org>
Hi Richard,
On 3/23/21 7:59 AM, Richard Henderson wrote:
> On 3/22/21 4:54 AM, Gavin Shan wrote:
>> It looks this issue can be avoided after "volatile" is applied to
>> @target_page. However, I'm not sure if it's the correct fix to have.
>
> Certainly not.
>
> That is the exact opposite of what we want. We want to minimize the number of reads from the variable, not maximize them.
>
Yes, It's something I was thinking of. "volatile" can make
@target_page visible to gcc, but maximizes the number of
reads. By the way, your patch to use "-fno-lto" worked for
me and it has been split into 3 patches by Phil. Richard,
thanks for the quick fixup :)
Thanks,
Gavin
prev parent reply other threads:[~2021-03-23 0:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 4:27 [PATCH] configure: Improve alias attribute check Gavin Shan
2021-03-20 4:48 ` Thomas Huth
2021-03-20 23:32 ` Gavin Shan
2021-03-20 17:52 ` Paolo Bonzini
2021-03-20 22:33 ` Richard Henderson
2021-03-20 23:36 ` Gavin Shan
2021-03-21 15:49 ` Richard Henderson
2021-03-21 16:50 ` Paolo Bonzini
2021-03-21 17:34 ` Richard Henderson
2021-03-21 17:43 ` Paolo Bonzini
2021-03-21 17:46 ` Paolo Bonzini
2021-03-21 18:23 ` Richard Henderson
2021-03-22 10:54 ` Gavin Shan
2021-03-22 20:59 ` Richard Henderson
2021-03-23 3:13 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1973a3-159a-6c1b-2767-29dcb91a6562@redhat.com \
--to=gshan@redhat.com \
--cc=aldyh@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).