qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] qapi-scheme/unicode-str test failure due to mismatch between e-acute and \xe9
Date: Tue, 7 May 2019 15:48:55 -0700	[thread overview]
Message-ID: <6d1e0ff7-1da8-59a9-a77b-adadfe1154d4@linaro.org> (raw)
In-Reply-To: <CAFEAcA9nd6Xta8CGSRp605i9bcpeKsj+h4r5gbpot4_iNKXyRg@mail.gmail.com>

On 5/7/19 3:37 PM, Peter Maydell wrote:
> I just ran into this test failure:
> 
> PYTHONPATH=/home/linux1/qemu/scripts python3 -B
> /home/linux1/qemu/tests/qapi-schema/test-qapi.py
> /home/linux1/qemu/tests/qapi-schema/unicode-str.json
>> tests/qapi-schema/unicode-str.test.out
> 2>tests/qapi-schema/unicode-str.test.err; echo $?
>> tests/qapi-schema/unicode-str.test.exit
> --- /home/linux1/qemu/tests/qapi-schema/unicode-str.err    2017-07-06
> 10:23:13.601812330 -0400
> +++ -    2019-05-07 18:32:31.533125931 -0400
> @@ -1 +1 @@
> -tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name 'é'
> +tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '\xe9'
> /home/linux1/qemu/tests/Makefile.include:1105: recipe for target
> 'check-tests/qapi-schema/unicode-str.json' failed
> make: *** [check-tests/qapi-schema/unicode-str.json] Error 1
> make: Leaving directory '/home/linux1/qemu/build/all'
> 
> but oddly only when I ran 'make check' by logging directly
> into this machine (usually I run the tests automatically
> via ssh and scripting), which suggests it may depend
> on the locale settings. Does anybody recognize this ?
> I think LANG=C fails, but LANG=C.UTF-8 passes.
> 
> Ideally our test suite should not depend on the locale
> or environment settings of the user running it.

Yes, there's an active thread about this:

https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg01247.html


r~


      reply	other threads:[~2019-05-07 22:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 22:37 [Qemu-devel] qapi-scheme/unicode-str test failure due to mismatch between e-acute and \xe9 Peter Maydell
2019-05-07 22:48 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d1e0ff7-1da8-59a9-a77b-adadfe1154d4@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).