From: Laszlo Ersek <lersek@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"patches@linaro.org" <patches@linaro.org>,
Drew Jones <drjones@redhat.com>,
Auger Eric <eric.auger@redhat.com>, Wei Huang <wei@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting
Date: Tue, 9 Jan 2018 16:58:56 +0100 [thread overview]
Message-ID: <6d20557d-5722-706f-ca4f-489ab85358c0@redhat.com> (raw)
In-Reply-To: <CAFEAcA8NbL7ROZs99hWhpAF2Rdi2qEiWLNo3hr_9W7gmgXyw4A@mail.gmail.com>
On 01/09/18 15:24, Peter Maydell wrote:
> Ping for code review?
>
> thanks
> -- PMM
>
> On 13 December 2017 at 16:52, Peter Maydell <peter.maydell@linaro.org> wrote:
>> The GICv2 and GICv3 specifications
here's where I had started running from your patch...
>> say that reserved register
>> addresses should RAZ/WI.
...and I remarked only looking over my shoulder that "RAZ/WI" is not a
verb :)
Sorry, no clue about any of this -- where should I read up?
Ard did ask a question though:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg500055.html
CC'ing Drew, Eric and Wei. In particular (IIUC) Eric has been looking
into a weird "why do we have so many (and so slow) aborts with GICv4
emulation" issue, at launching UEFI.
Thanks
Laszlo
>> This means we need to return MEMTX_OK, not
>> MEMTX_ERROR, because now that we support generating external aborts
>> the latter will cause an abort on new board models.
>>
>> In particular, at least some versions of UEFI try to
>> access a reserved address in the GICv3 redistributor
>> (at SGI_base + 0x184) and fail to boot on the virt board
>> without this.
>>
>> thanks
>> -- PMM
>>
>> Peter Maydell (2):
>> hw/intc/arm_gicv3: Make reserved register addresses RAZ/WI
>> hw/intc/arm_gic: reserved register addresses are RAZ/WI
>>
>> hw/intc/arm_gic.c | 5 +++--
>> hw/intc/arm_gicv3_dist.c | 13 +++++++++++++
>> hw/intc/arm_gicv3_its_common.c | 8 +++-----
>> hw/intc/arm_gicv3_redist.c | 13 +++++++++++++
>> 4 files changed, 32 insertions(+), 7 deletions(-)
next prev parent reply other threads:[~2018-01-09 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 16:52 [Qemu-devel] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting Peter Maydell
2017-12-13 16:52 ` [Qemu-devel] [PATCH 1/2] hw/intc/arm_gicv3: Make reserved register addresses RAZ/WI Peter Maydell
2018-01-09 21:43 ` Alistair Francis
2017-12-13 16:52 ` [Qemu-devel] [PATCH 2/2] hw/intc/arm_gic: reserved register addresses are RAZ/WI Peter Maydell
2018-01-09 21:41 ` Alistair Francis
2017-12-13 16:54 ` [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting Peter Maydell
2017-12-14 12:59 ` Ard Biesheuvel
2018-01-09 14:24 ` Peter Maydell
2018-01-09 15:58 ` Laszlo Ersek [this message]
2018-01-09 16:12 ` Peter Maydell
2018-01-09 16:29 ` Laszlo Ersek
2018-01-09 16:35 ` Peter Maydell
2018-01-09 16:48 ` Laszlo Ersek
2018-01-09 18:48 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d20557d-5722-706f-ca4f-489ab85358c0@redhat.com \
--to=lersek@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).