Avocado 88.1 vs Python 3.12

Avocado 88.1 vs Python 3.12

[Richard Henderson]

Hi guys,

I have reinstalled my development box to ubuntu 24 (because the Rust support is better 
than my previous install; ho hum).  I thought I had tested everything in a VM before 
committing, but I missed out on Avocado:

>   AVOCADO Downloading avocado tests VM image for aarch64
> Failed to load plugin from module "avocado.plugins.list": ModuleNotFoundError("No module named 'imp'") :
>   File "/home/rth/qemu/bld/pyvenv/lib/python3.12/site-packages/avocado/core/extension_manager.py", line 63, in __init__
>     plugin = ep.load()
>              ^^^^^^^^^
>   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2518, in load
>     return self.resolve()
>            ^^^^^^^^^^^^^^
>   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2524, in resolve
>     module = __import__(self.module_name, fromlist=['__name__'], level=0)
>              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/home/rth/qemu/bld/pyvenv/lib/python3.12/site-packages/avocado/plugins/list.py", line 19, in <module>
>     from avocado.core import exit_codes, loader, parser_common_args
>   File "/home/rth/qemu/bld/pyvenv/lib/python3.12/site-packages/avocado/core/loader.py", line 20, in <module>
>     import imp

If I understand things correctly, the python "imp" package was deprecated, and has been 
removed before v3.12.  This is fixed in upstream avocado as of v93.  But we have a hard 
stop in pythondeps.toml at v92.

Remind me what the blocker is to upgrading?


r~

Re: Avocado 88.1 vs Python 3.12

[Philippe Mathieu-Daudé]

On 9/7/24 17:41, Richard Henderson wrote:
> Hi guys,
> 
> I have reinstalled my development box to ubuntu 24 (because the Rust 
> support is better than my previous install; ho hum).  I thought I had 
> tested everything in a VM before committing, but I missed out on Avocado:
> 
>>   AVOCADO Downloading avocado tests VM image for aarch64
>> Failed to load plugin from module "avocado.plugins.list": 
>> ModuleNotFoundError("No module named 'imp'") :


> If I understand things correctly, the python "imp" package was 
> deprecated, and has been removed before v3.12.  This is fixed in 
> upstream avocado as of v93.  But we have a hard stop in pythondeps.toml 
> at v92.
> 
> Remind me what the blocker is to upgrading?

IIRC we're waiting for v2 of:
https://lore.kernel.org/qemu-devel/20231208190911.102879-1-crosa@redhat.com/

Re: Avocado 88.1 vs Python 3.12

[Richard Henderson]

On 7/9/24 09:26, Philippe Mathieu-Daudé wrote:
> On 9/7/24 17:41, Richard Henderson wrote:
>> Hi guys,
>>
>> I have reinstalled my development box to ubuntu 24 (because the Rust support is better 
>> than my previous install; ho hum).  I thought I had tested everything in a VM before 
>> committing, but I missed out on Avocado:
>>
>>>   AVOCADO Downloading avocado tests VM image for aarch64
>>> Failed to load plugin from module "avocado.plugins.list": ModuleNotFoundError("No 
>>> module named 'imp'") :
> 
> 
>> If I understand things correctly, the python "imp" package was deprecated, and has been 
>> removed before v3.12.  This is fixed in upstream avocado as of v93.  But we have a hard 
>> stop in pythondeps.toml at v92.
>>
>> Remind me what the blocker is to upgrading?
> 
> IIRC we're waiting for v2 of:
> https://lore.kernel.org/qemu-devel/20231208190911.102879-1-crosa@redhat.com/
> 
> 

Yes indeed.  There are two minor conflicts in rebasing this branch, but otherwise it 
works.  Cleber, do you have time to pick this up again?


r~

Re: Avocado 88.1 vs Python 3.12

[Thomas Huth]

On 10/07/2024 01.45, Richard Henderson wrote:
> On 7/9/24 09:26, Philippe Mathieu-Daudé wrote:
>> On 9/7/24 17:41, Richard Henderson wrote:
>>> Hi guys,
>>>
>>> I have reinstalled my development box to ubuntu 24 (because the Rust 
>>> support is better than my previous install; ho hum).  I thought I had 
>>> tested everything in a VM before committing, but I missed out on Avocado:
>>>
>>>>   AVOCADO Downloading avocado tests VM image for aarch64
>>>> Failed to load plugin from module "avocado.plugins.list": 
>>>> ModuleNotFoundError("No module named 'imp'") :
>>
>>
>>> If I understand things correctly, the python "imp" package was 
>>> deprecated, and has been removed before v3.12.  This is fixed in upstream 
>>> avocado as of v93.  But we have a hard stop in pythondeps.toml at v92.
>>>
>>> Remind me what the blocker is to upgrading?
>>
>> IIRC we're waiting for v2 of:
>> https://lore.kernel.org/qemu-devel/20231208190911.102879-1-crosa@redhat.com/
> 
> Yes indeed.  There are two minor conflicts in rebasing this branch, but 
> otherwise it works.  Cleber, do you have time to pick this up again?

As an alternative, if nobody has time to work on that Avocado update, we 
could maybe also try to integrate the python-based tests directly with the 
meson test runner. A prototype can be found here:

  https://lore.kernel.org/qemu-devel/20240711115546.40859-1-thuth@redhat.com/

  Thomas

Re: Avocado 88.1 vs Python 3.12

[Daniel P. Berrangé]

On Thu, Jul 11, 2024 at 02:01:25PM +0200, Thomas Huth wrote:
> On 10/07/2024 01.45, Richard Henderson wrote:
> > On 7/9/24 09:26, Philippe Mathieu-Daudé wrote:
> > > On 9/7/24 17:41, Richard Henderson wrote:
> > > > Hi guys,
> > > > 
> > > > I have reinstalled my development box to ubuntu 24 (because the
> > > > Rust support is better than my previous install; ho hum).  I
> > > > thought I had tested everything in a VM before committing, but I
> > > > missed out on Avocado:
> > > > 
> > > > >   AVOCADO Downloading avocado tests VM image for aarch64
> > > > > Failed to load plugin from module "avocado.plugins.list":
> > > > > ModuleNotFoundError("No module named 'imp'") :
> > > 
> > > 
> > > > If I understand things correctly, the python "imp" package was
> > > > deprecated, and has been removed before v3.12.  This is fixed in
> > > > upstream avocado as of v93.  But we have a hard stop in
> > > > pythondeps.toml at v92.
> > > > 
> > > > Remind me what the blocker is to upgrading?
> > > 
> > > IIRC we're waiting for v2 of:
> > > https://lore.kernel.org/qemu-devel/20231208190911.102879-1-crosa@redhat.com/
> > 
> > Yes indeed.  There are two minor conflicts in rebasing this branch, but
> > otherwise it works.  Cleber, do you have time to pick this up again?
> 
> As an alternative, if nobody has time to work on that Avocado update, we
> could maybe also try to integrate the python-based tests directly with the
> meson test runner. A prototype can be found here:
> 
>  https://lore.kernel.org/qemu-devel/20240711115546.40859-1-thuth@redhat.com/

Ooh, that looks remarkably straightford. I'd love to see use using pytest as
the test harness, even if we keep using avocado framework in some of the
test case impls. 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|