qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Fontana <cfontana@suse.de>
To: Fabiano Rosas <farosas@suse.de>, Peter Xu <peterx@redhat.com>,
	qemu-devel@nongnu.org
Cc: Juraj Marcin <jmarcin@redhat.com>
Subject: Re: [PATCH] migration/options: Add x-ignore-shared
Date: Mon, 8 Dec 2025 16:44:25 +0100	[thread overview]
Message-ID: <6d36351f-5faf-449d-9de1-0db1fedf394d@suse.de> (raw)
In-Reply-To: <87h5u1kmku.fsf@suse.de>

On 12/8/25 16:41, Fabiano Rosas wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
>> This aids scriptings only.
>>
>> Signed-off-by: Peter Xu <peterx@redhat.com>
>> ---
>>  migration/options.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/migration/options.c b/migration/options.c
>> index e78324b80c..30bf9afaf0 100644
>> --- a/migration/options.c
>> +++ b/migration/options.c
>> @@ -203,6 +203,7 @@ const Property migration_properties[] = {
>>                          MIGRATION_CAPABILITY_SWITCHOVER_ACK),
>>      DEFINE_PROP_MIG_CAP("x-dirty-limit", MIGRATION_CAPABILITY_DIRTY_LIMIT),
>>      DEFINE_PROP_MIG_CAP("mapped-ram", MIGRATION_CAPABILITY_MAPPED_RAM),
>> +    DEFINE_PROP_MIG_CAP("x-ignore-share", MIGRATION_CAPABILITY_X_IGNORE_SHARED),
>>  };
>>  const size_t migration_properties_count = ARRAY_SIZE(migration_properties);
> 
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> 

Nit: x-ignore-shared or x-ignore-share ? Commit msg and code seem to disagree.

Ciao,

C


  reply	other threads:[~2025-12-08 15:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 17:20 [PATCH] migration/options: Add x-ignore-shared Peter Xu
2025-12-08 15:41 ` Fabiano Rosas
2025-12-08 15:44   ` Claudio Fontana [this message]
2025-12-08 16:32     ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d36351f-5faf-449d-9de1-0db1fedf394d@suse.de \
    --to=cfontana@suse.de \
    --cc=farosas@suse.de \
    --cc=jmarcin@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).