From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alastair D'Silva" <alastair@au1.ibm.com>,
"Cédric Le Goater" <clg@kaod.org>,
qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>
Subject: Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts
Date: Tue, 22 Nov 2016 23:39:02 +0100 [thread overview]
Message-ID: <6d4e34f8-4b0b-85f2-93d6-6f0b3e2e7fb3@redhat.com> (raw)
In-Reply-To: <1479853887.11116.95.camel@au1.ibm.com>
On 22/11/2016 23:31, Alastair D'Silva wrote:
>>>> > > > + if (irq == NULL) {
>>>> > > > + qtest_send_prefix(chr);
>>>> > > > + qtest_send(chr, "FAIL Unknown IRQ\n");
>>>> > > > + return;
>>>> > > > + }
>>>> > > > +
>>>> > > > + qemu_set_irq(irq, level);
>> >
>> > This seems wrong. The IRQ should not be modifiable by the test.
>> >
>> > Paolo
>> >
> Thanks Paolo, could you please advise as to why that is?
>
> The situation I am addressing is that I device under test that changes
> behaviour when a GPIO line is raised. Is there another way I should be
> raising that line from within qtest?
What causes the GPIO line to be raised in the normal emulated case?
Paolo
next prev parent reply other threads:[~2016-11-22 22:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 4:36 [Qemu-devel] [PATCH 0/4] Add support for the Epson RX8900 RTC to the aspeed board Alastair D'Silva
2016-11-17 4:36 ` [Qemu-devel] [PATCH 1/4] arm: Uniquely name imx25 I2C buses Alastair D'Silva
2016-11-17 7:50 ` Cédric Le Goater
2016-11-17 4:36 ` [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts Alastair D'Silva
2016-11-22 17:22 ` Cédric Le Goater
2016-11-22 17:24 ` Paolo Bonzini
2016-11-22 22:31 ` Alastair D'Silva
2016-11-22 22:39 ` Paolo Bonzini [this message]
2016-11-22 23:19 ` Alastair D'Silva
2016-11-23 9:43 ` Paolo Bonzini
2016-11-23 10:05 ` [Qemu-devel] [Qemu-arm] " Edgar E. Iglesias
2016-11-23 10:34 ` Paolo Bonzini
2016-11-17 4:36 ` [Qemu-devel] [PATCH 3/4] hw/timer: Add Epson RX8900 RTC support Alastair D'Silva
2016-11-17 8:29 ` Cédric Le Goater
2016-11-18 0:19 ` Alastair D'Silva
2016-11-18 8:52 ` Cédric Le Goater
2016-11-17 4:36 ` [Qemu-devel] [PATCH 4/4] arm: Add an RX8900 RTC to the ASpeed board Alastair D'Silva
2016-11-22 16:56 ` Cédric Le Goater
2016-11-23 0:46 ` Alastair D'Silva
2016-11-23 8:48 ` Cédric Le Goater
2016-11-24 0:15 ` Andrew Jeffery
2016-11-17 15:33 ` [Qemu-devel] [PATCH 0/4] Add support for the Epson RX8900 RTC to the aspeed board no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d4e34f8-4b0b-85f2-93d6-6f0b3e2e7fb3@redhat.com \
--to=pbonzini@redhat.com \
--cc=alastair@au1.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).