From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9Jib-0008GG-R1 for qemu-devel@nongnu.org; Tue, 22 Nov 2016 17:39:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9Jib-0002wf-1y for qemu-devel@nongnu.org; Tue, 22 Nov 2016 17:39:13 -0500 References: <1479357400-17441-1-git-send-email-alastair@au1.ibm.com> <1479357400-17441-3-git-send-email-alastair@au1.ibm.com> <3888651b-fd60-e827-a9f8-575a8f01be72@redhat.com> <1479853887.11116.95.camel@au1.ibm.com> From: Paolo Bonzini Message-ID: <6d4e34f8-4b0b-85f2-93d6-6f0b3e2e7fb3@redhat.com> Date: Tue, 22 Nov 2016 23:39:02 +0100 MIME-Version: 1.0 In-Reply-To: <1479853887.11116.95.camel@au1.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alastair D'Silva , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, Peter Maydell , Andrew Jeffery , Joel Stanley On 22/11/2016 23:31, Alastair D'Silva wrote: >>>> > > > + if (irq == NULL) { >>>> > > > + qtest_send_prefix(chr); >>>> > > > + qtest_send(chr, "FAIL Unknown IRQ\n"); >>>> > > > + return; >>>> > > > + } >>>> > > > + >>>> > > > + qemu_set_irq(irq, level); >> > >> > This seems wrong. The IRQ should not be modifiable by the test. >> > >> > Paolo >> > > Thanks Paolo, could you please advise as to why that is? > > The situation I am addressing is that I device under test that changes > behaviour when a GPIO line is raised. Is there another way I should be > raising that line from within qtest? What causes the GPIO line to be raised in the normal emulated case? Paolo