From: Paolo Bonzini <pbonzini@redhat.com>
To: Artem Pisarenko <artem.k.pisarenko@gmail.com>, qemu-devel@nongnu.org
Cc: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH 0/3] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type
Date: Mon, 15 Oct 2018 10:54:05 +0200 [thread overview]
Message-ID: <6d5c6b1e-c52b-815c-6579-1992d4a963b0@redhat.com> (raw)
In-Reply-To: <cover.1539528213.git.artem.k.pisarenko@gmail.com>
On 14/10/2018 16:55, Artem Pisarenko wrote:
>
> Current implementation of timers/clock processing is confusing (at
> least for me) because of exceptions from design concept behind them,
> introduced by icount mode (which adds QEMU_CLOCK_VIRTUAL_RT). Adding
> QEMU_CLOCK_VIRTUAL_EXT just made things even more complicated. I
> consider these "alternative" virtual clocks to be some kind of hacks
> being convinient only to authors of relevant qemu features. Lets
> don't touch fundamental clock types and keep them orthogonal to
> special cases of timers handling.
VIRTUAL_RT is clear I believe, and it's used even beyond record/replay.
However, I agree that VIRTUAL_EXT is messy and I like this series a lot.
Paolo
prev parent reply other threads:[~2018-10-15 8:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 14:55 [Qemu-devel] [PATCH 0/3] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type Artem Pisarenko
2018-10-14 14:55 ` [Qemu-devel] [PATCH 1/3] Revert some patches from recent series [PATCH v6] "Fixing record/replay and adding reverse debugging", which introduced new virtual clock type for use in external subsystems. These changes breaks desired behavior in non-record/replay usage scenarios Artem Pisarenko
2018-10-14 14:55 ` [Qemu-devel] [PATCH 2/3] Introduce attributes to qemu timer subsystem Artem Pisarenko
2018-10-15 8:39 ` Paolo Bonzini
2018-10-16 13:03 ` [Qemu-devel] [PATCH v2] " Artem Pisarenko
2018-10-16 13:47 ` Paolo Bonzini
2018-10-14 14:55 ` [Qemu-devel] [PATCH 3/3] Restores record/replay behavior related to special virtual clock processing for timers used in external subsystems Artem Pisarenko
2018-10-15 6:41 ` Artem Pisarenko
2018-10-15 8:51 ` Paolo Bonzini
2018-10-15 8:54 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d5c6b1e-c52b-815c-6579-1992d4a963b0@redhat.com \
--to=pbonzini@redhat.com \
--cc=artem.k.pisarenko@gmail.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).