From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com,
mark.cave-ayland@ilande.co.uk, frederic.konrad@adacore.com,
kraxel@redhat.com, edgar.iglesias@gmail.com, jcd@tribudubois.net,
qemu-block@nongnu.org, quintela@redhat.com,
andrew.smirnov@gmail.com, marcandre.lureau@redhat.com,
atar4qemu@gmail.com, ehabkost@redhat.com, alistair@alistair23.me,
dgilbert@redhat.com, chouteau@adacore.com, qemu-arm@nongnu.org,
peter.chubb@nicta.com.au, jsnow@redhat.com, kwolf@redhat.com,
berrange@redhat.com, mreitz@redhat.com
Subject: Re: [PATCH RFC 1/1] hw: Replace anti-social QOM type names
Date: Fri, 29 Jan 2021 10:06:20 +0100 [thread overview]
Message-ID: <6d69c392-1c53-cc35-d504-0ada33ca37c5@redhat.com> (raw)
In-Reply-To: <20210129081519.3848145-2-armbru@redhat.com>
On 29/01/21 09:15, Markus Armbruster wrote:
> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> index 7fc547c62d..0dd158bf73 100644
> --- a/hw/block/fdc.c
> +++ b/hw/block/fdc.c
> @@ -2547,7 +2547,7 @@ void sun4m_fdctrl_init(qemu_irq irq, hwaddr io_base,
> DeviceState *dev;
> FDCtrlSysBus *sys;
>
> - dev = qdev_new("SUNW,fdtwo");
> + dev = qdev_new("SUNW-fdtwo");
> sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
> sys = SYSBUS_FDC(dev);
> sysbus_connect_irq(SYS_BUS_DEVICE(sys), 0, irq);
Missing:
fdc_name = object_get_typename(OBJECT(fdc_dev));
drive_suffix = !strcmp(fdc_name, "SUNW,fdtwo") ? "" : i ? "B" :
"A";
warn_report("warning: property %s.drive%s is deprecated",
fdc_name, drive_suffix);
error_printf("Use -device floppy,unit=%d,drive=... instead.\n", i);
next prev parent reply other threads:[~2021-01-29 9:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 8:15 [PATCH RFC 0/1] QOM type names and QAPI Markus Armbruster
2021-01-29 8:15 ` [PATCH RFC 1/1] hw: Replace anti-social QOM type names Markus Armbruster
2021-01-29 9:06 ` Paolo Bonzini [this message]
2021-01-29 9:18 ` Markus Armbruster
2021-02-01 20:45 ` Mark Cave-Ayland
2021-02-02 9:21 ` Markus Armbruster
2021-01-29 9:17 ` [PATCH RFC 0/1] QOM type names and QAPI Markus Armbruster
2021-01-29 11:54 ` Markus Armbruster
2021-01-29 12:01 ` Peter Maydell
2021-01-29 12:17 ` Daniel P. Berrangé
2021-01-29 13:25 ` Paolo Bonzini
2021-02-01 21:31 ` Eduardo Habkost
2021-02-02 9:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d69c392-1c53-cc35-d504-0ada33ca37c5@redhat.com \
--to=pbonzini@redhat.com \
--cc=alistair@alistair23.me \
--cc=andrew.smirnov@gmail.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=berrange@redhat.com \
--cc=chouteau@adacore.com \
--cc=dgilbert@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=jcd@tribudubois.net \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).