From: Jason Wang <jasowang@redhat.com>
To: anton.ivanov@cambridgegreys.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Unified Datagram Socket Transport
Date: Fri, 21 Jul 2017 11:55:06 +0800 [thread overview]
Message-ID: <6d89f581-fc89-3455-60c8-439702d7bba6@redhat.com> (raw)
In-Reply-To: <20170720191228.12342-1-anton.ivanov@cambridgegreys.com>
On 2017年07月21日 03:12, anton.ivanov@cambridgegreys.com wrote:
> Hi all,
>
> This addresses comments so far except Eric's suggestion to use
> InetSocketAddressBase. If I understand correctly its intended use,
> it will not be of help for protocols which have no port (raw
> sockets - GRE, L2TPv3, etc).
>
> It also includes a port of the original socket.c transport to
> the new UDST backend. The relevant code is ifdef-ed so there
> should be no effect on other systems.
This looks sub-optimal. If you want to do this, I would rather suggest
you just extend the socket dgram backend like what udst did now.
>
> I think that this is would be the appropriate place to stop in this
> iteration. I would prefer to have this polished, before I start
> looking at sendmmsg and bulk send or some of the more unpleasant
> encapsulations like geneve.
Pay attention we're softfreeze now. So the feature is for 2.11, if it
looks good, I can only queue it for 2.11.
Btw, looks like not all comments of v1 were addressed.
Thanks
>
> A.
>
>
next prev parent reply other threads:[~2017-07-21 4:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 19:12 [Qemu-devel] Unified Datagram Socket Transport anton.ivanov
2017-07-20 19:12 ` [Qemu-devel] [PATCH v2 1/5] Unified Datagram Socket Transports anton.ivanov
2017-07-20 19:12 ` [Qemu-devel] [PATCH v2 2/5] Migrate l2tpv3 to UDST Backend anton.ivanov
2017-07-20 19:12 ` [Qemu-devel] [PATCH v2 3/5] GRETAP Backend for UDST anton.ivanov
2017-07-20 19:12 ` [Qemu-devel] [PATCH v2 4/5] Raw " anton.ivanov
2017-07-20 19:12 ` [Qemu-devel] [PATCH v2 5/5] Migrate Datagram operation in socket transport to UDST anton.ivanov
2017-07-21 3:55 ` Jason Wang [this message]
2017-07-21 4:25 ` [Qemu-devel] Unified Datagram Socket Transport Anton Ivanov
2017-07-24 3:17 ` Jason Wang
2017-07-24 6:15 ` Anton Ivanov
2017-07-21 19:05 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d89f581-fc89-3455-60c8-439702d7bba6@redhat.com \
--to=jasowang@redhat.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).