Re: [PATCH 02/12] target/ppc: Remove superfluous breaks

[Laurent Vivier <laurent@vivier.eu>]

Le 13/07/2020 à 11:30, Thomas Huth a écrit :
> On 13/07/2020 11.03, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove superfluous breaks, as there is a "return" before them.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> 
>> ---
>>  target/ppc/misc_helper.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
>> index 55b68d1..e43a3b4 100644
>> --- a/target/ppc/misc_helper.c
>> +++ b/target/ppc/misc_helper.c
>> @@ -234,25 +234,20 @@ target_ulong helper_clcs(CPUPPCState *env, uint32_t arg)
>>      case 0x0CUL:
>>          /* Instruction cache line size */
>>          return env->icache_line_size;
>> -        break;
>>      case 0x0DUL:
>>          /* Data cache line size */
>>          return env->dcache_line_size;
>> -        break;
>>      case 0x0EUL:
>>          /* Minimum cache line size */
>>          return (env->icache_line_size < env->dcache_line_size) ?
>>              env->icache_line_size : env->dcache_line_size;
>> -        break;
>>      case 0x0FUL:
>>          /* Maximum cache line size */
>>          return (env->icache_line_size > env->dcache_line_size) ?
>>              env->icache_line_size : env->dcache_line_size;
>> -        break;
>>      default:
>>          /* Undefined */
>>          return 0;
>> -        break;
>>      }
>>  }
>>  
>>
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> 

Applied to my trivial-patches branch.

Thanks,
Laurent