From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/4] block: Use bdrv_make_empty() where possible
Date: Tue, 28 Apr 2020 08:54:58 -0500 [thread overview]
Message-ID: <6d94e65e-b65b-4583-c66e-86cc390a3ec9@redhat.com> (raw)
In-Reply-To: <20200428132629.796753-3-mreitz@redhat.com>
On 4/28/20 8:26 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/replication.c | 6 ++----
> block/vvfat.c | 4 +---
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
Yes, definitely nicer :) May have some obvious fallout to add a 0 flag
parameter, per my request on 1/4, but that doesn't stop me from giving:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-04-28 14:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 13:26 [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly Max Reitz
2020-04-28 13:26 ` [PATCH 1/4] block: Add bdrv_make_empty() Max Reitz
2020-04-28 13:53 ` Eric Blake
2020-04-28 14:01 ` Kevin Wolf
2020-04-28 14:07 ` Eric Blake
2020-04-28 14:16 ` Kevin Wolf
2020-04-28 14:25 ` Eric Blake
2020-04-28 14:21 ` Kevin Wolf
2020-04-29 7:39 ` Max Reitz
2020-04-28 13:26 ` [PATCH 2/4] block: Use bdrv_make_empty() where possible Max Reitz
2020-04-28 13:54 ` Eric Blake [this message]
2020-04-28 15:03 ` Kevin Wolf
2020-04-28 13:26 ` [PATCH 3/4] block: Add blk_make_empty() Max Reitz
2020-04-28 13:55 ` Eric Blake
2020-04-28 14:28 ` Eric Blake
2020-04-28 14:47 ` Kevin Wolf
2020-04-29 7:39 ` Max Reitz
2020-04-28 13:26 ` [PATCH 4/4] block: Use blk_make_empty() after commits Max Reitz
2020-04-28 14:07 ` Eric Blake
2020-04-29 7:58 ` Max Reitz
2020-04-28 15:03 ` Kevin Wolf
2020-04-29 8:01 ` Max Reitz
2020-04-28 13:38 ` [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly no-reply
2020-04-28 13:43 ` no-reply
2020-04-28 13:57 ` Eric Blake
2020-04-28 13:48 ` no-reply
2020-04-28 13:49 ` Eric Blake
2020-04-28 14:05 ` Eric Blake
2020-04-28 14:53 ` no-reply
2020-04-28 14:57 ` no-reply
2020-04-28 15:02 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d94e65e-b65b-4583-c66e-86cc390a3ec9@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).