From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Subject: Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState
Date: Tue, 17 Jan 2023 11:01:37 -1000 [thread overview]
Message-ID: <6da18e97-c80e-1ac2-edca-34fb243edd81@linaro.org> (raw)
In-Reply-To: <20230117184217.83305-1-philmd@linaro.org>
On 1/17/23 08:42, Philippe Mathieu-Daudé wrote:
> Remove dead code:
> - unused fields in CPUTriCoreState
> - (unexisting) tricore_def_t structure
> - forward declaration of tricore_boot_info structure
> (declared in "hw/tricore/tricore.h", used once in
> hw/tricore/tricore_testboard.c).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Given this compiles,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
It did surprise me though, since I would have expected something to use hflags. It turns
out the only thing that uses TRICORE_HFLAG_* is the kernel vs user-mode bits.
Bastian, there is code missing from cpu_get_tb_cpu_state, to copy env->PSW[11:10] to
*flags. At present it would seem that all code effectively runs in kernel mode.
r~
next prev parent reply other threads:[~2023-01-17 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 18:42 [PATCH] target/tricore: Remove unused fields from CPUTriCoreState Philippe Mathieu-Daudé
2023-01-17 21:01 ` Richard Henderson [this message]
2023-01-18 9:03 ` Bastian Koppelmann
2023-01-18 18:37 ` Richard Henderson
2023-01-18 9:05 ` Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da18e97-c80e-1ac2-edca-34fb243edd81@linaro.org \
--to=richard.henderson@linaro.org \
--cc=kbastian@mail.uni-paderborn.de \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).