From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 0/2] memory: fix alignment checks/asserts
Date: Mon, 11 Jun 2018 15:30:51 +0200 [thread overview]
Message-ID: <6da8d892-fa42-c870-7be2-bded1ab4e28f@redhat.com> (raw)
In-Reply-To: <20180607154705.6316-1-david@redhat.com>
On 07/06/2018 17:47, David Hildenbrand wrote:
> We can currently hit two asserts. Let's fix those.
>
> Patch nr. 1 is a result from:
> "[PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers"
>
> We treat right now any alignment > 1GB as a violation, as it would
> fragment guest memory heavily. Turn the assert into a check.
>
> Also, we run into an assert when using alignments that are not a power of
> two.
Queued, thanks.
Paolo
prev parent reply other threads:[~2018-06-11 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 15:47 [Qemu-devel] [PATCH v1 0/2] memory: fix alignment checks/asserts David Hildenbrand
2018-06-07 15:47 ` [Qemu-devel] [PATCH v1 1/2] memory-device: turn alignment assert into check David Hildenbrand
2018-06-08 8:28 ` Igor Mammedov
2018-06-07 15:47 ` [Qemu-devel] [PATCH v1 2/2] exec: check that alignment is a power of two David Hildenbrand
2018-06-08 8:30 ` Igor Mammedov
2018-06-07 22:01 ` [Qemu-devel] [PATCH v1 0/2] memory: fix alignment checks/asserts Michael S. Tsirkin
2018-06-11 13:30 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da8d892-fa42-c870-7be2-bded1ab4e28f@redhat.com \
--to=pbonzini@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).