From: Maxim Levitsky <mlevitsk@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Cornelia Huck <cohuck@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm.
Date: Thu, 01 Apr 2021 20:10:56 +0300 [thread overview]
Message-ID: <6db4acb8ce2d1ddb271cd7de465f1db4744ed1d4.camel@redhat.com> (raw)
In-Reply-To: <d221fa13-8e3b-0666-ff15-8c86d4e08237@redhat.com>
On Thu, 2021-04-01 at 18:09 +0200, Paolo Bonzini wrote:
> On 01/04/21 16:45, Maxim Levitsky wrote:
> > +
> > + for (i = 0; i < 4; i++) {
> > + sregs.pdptrs[i] = env->pdptrs[i];
> > + }
> > +
> > + sregs.flags = 0;
> > + sregs.padding = 0;
> > +
> > + return kvm_vcpu_ioctl(CPU(cpu), KVM_SET_SREGS2, &sregs);
> > +}
> > +
>
> This breaks when migrating from old to new kernel, because in that case
> the PDPTRs are not initialized.
True, I haven't thought about it!
I'll fix this in the next version.
Best regards,
Maxim Levitsky
>
> Paolo
>
prev parent reply other threads:[~2021-04-01 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 14:45 [PATCH 0/2] kvm: use KVM_{GET|SET}_SREGS2 when available Maxim Levitsky
2021-04-01 14:45 ` [PATCH 1/2] kvm: update kernel headers for KVM_{GET|SET}_SREGS2 Maxim Levitsky
2021-04-01 14:45 ` [PATCH 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm Maxim Levitsky
2021-04-01 16:09 ` Paolo Bonzini
2021-04-01 17:10 ` Maxim Levitsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db4acb8ce2d1ddb271cd7de465f1db4744ed1d4.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).