From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJCNp-0005hs-U6 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 03:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJCN1-0006Vd-Dw for qemu-devel@nongnu.org; Wed, 24 Apr 2019 03:31:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52124) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJCN1-0006To-60 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 03:31:07 -0400 References: <20190420100056.116305-1-liq3ea@163.com> <20190420100056.116305-4-liq3ea@163.com> From: Thomas Huth Message-ID: <6dd699b1-f24d-743b-343e-f1df6c8672b9@redhat.com> Date: Wed, 24 Apr 2019 09:30:56 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Qiang Cc: Li Qiang , lvivier@redhat.com, Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Laszlo Ersek , Gerd Hoffmann , Qemu Developers On 24/04/2019 03.16, Li Qiang wrote: >=20 > Thomas Huth > =E4=BA=8E2019=E5= =B9=B44=E6=9C=8824=E6=97=A5 > =E5=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=8812:29=E5=86=99=E9=81=93=EF=BC=9A >=20 > On 20/04/2019 12.00, Li Qiang wrote: > > Signed-off-by: Li Qiang > > > --- > >=C2=A0 tests/fw_cfg-test.c | 19 +++++++++++++++++++ > >=C2=A0 1 file changed, 19 insertions(+) > > > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > > index c22503619f..9f75dbb5f4 100644 > > --- a/tests/fw_cfg-test.c > > +++ b/tests/fw_cfg-test.c > > @@ -174,6 +174,24 @@ static void test_fw_cfg_boot_menu(void) > >=C2=A0 =C2=A0 =C2=A0 qtest_quit(s); > >=C2=A0 } > >=C2=A0 > > +static void test_fw_cfg_reboot_timeout(void) > > +{ > > +=C2=A0 =C2=A0 QFWCFG *fw_cfg; > > +=C2=A0 =C2=A0 QTestState *s; > > +=C2=A0 =C2=A0 uint32_t reboot_timeout =3D 0; > > +=C2=A0 =C2=A0 size_t filesize; > > + > > +=C2=A0 =C2=A0 s =3D qtest_init("-boot reboot-timeout=3D15"); > > +=C2=A0 =C2=A0 fw_cfg =3D pc_fw_cfg_init(s); > > + > > +=C2=A0 =C2=A0 filesize =3D qfw_cfg_get_file(fw_cfg, "etc/boot-fa= il-wait", > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0&reboot_timeout, sizeof(reboot_timeout)); > > +=C2=A0 =C2=A0 g_assert_cmpint(filesize, =3D=3D, sizeof(reboot_ti= meout)); > > +=C2=A0 =C2=A0 g_assert_cmpint(reboot_timeout, =3D=3D, 15); >=20 > Is this endianess-safe? Or do you need to byteswap reboot_timeout i= f the > host and guest endianess does not match? >=20 > Good question! >=20 > IIUC, the qemu fw_cfg store the 'file' entry data just in byte stream. > So there is no need > to consider the file's endianess. If when the file entry is stored > without considering endianess, > it will be ok to ignore the endianess. So for this patch, the > 'reboot_timeout' is ok as when we stored=C2=A0 > it we don't consider endianess. But for 'splash-time', when we stored > it=C2=A0 we convert it to little endian > so when we fetches it, we should also convert it from little endian to > cpu-endian. I just gave these patches a try on a big endian host, and the test fails indeed: $ QTEST_QEMU_BINARY=3Dx86_64-softmmu/qemu-system-x86_64 tests/fw_cfg-test /x86_64/fw_cfg/signature: OK /x86_64/fw_cfg/id: OK /x86_64/fw_cfg/uuid: OK /x86_64/fw_cfg/ram_size: OK /x86_64/fw_cfg/nographic: OK /x86_64/fw_cfg/nb_cpus: OK /x86_64/fw_cfg/max_cpus: OK /x86_64/fw_cfg/numa: OK /x86_64/fw_cfg/boot_menu: OK /x86_64/fw_cfg/reboot_timeout: ** ERROR:tests/fw_cfg-test.c:190:test_fw_cfg_reboot_timeout: assertion failed (reboot_timeout =3D=3D 15): (0 =3D=3D 15) Aborted =3D> it also fails for reboot_timeout already, not only for splash_time. > So I think we can have following choose: >=20 > 1. Don't consider the endianess, this is ok when emaulated target and > host target has the same endianess. Sorry, but that's not a real choice. qtests must also work when you e.g. run qemu-system-x86_64 on a big endian host. Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D57C10F11 for ; Wed, 24 Apr 2019 07:33:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2057A2089F for ; Wed, 24 Apr 2019 07:33:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2057A2089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:37261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJCPg-0006oy-0K for qemu-devel@archiver.kernel.org; Wed, 24 Apr 2019 03:33:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJCNp-0005hs-U6 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 03:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJCN1-0006Vd-Dw for qemu-devel@nongnu.org; Wed, 24 Apr 2019 03:31:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52124) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJCN1-0006To-60 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 03:31:07 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 513313098488; Wed, 24 Apr 2019 07:31:04 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-69.ams2.redhat.com [10.36.116.69]) by smtp.corp.redhat.com (Postfix) with ESMTP id B9D2C5C28D; Wed, 24 Apr 2019 07:30:57 +0000 (UTC) To: Li Qiang References: <20190420100056.116305-1-liq3ea@163.com> <20190420100056.116305-4-liq3ea@163.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: <6dd699b1-f24d-743b-343e-f1df6c8672b9@redhat.com> Date: Wed, 24 Apr 2019 09:30:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 24 Apr 2019 07:31:04 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Li Qiang , Qemu Developers , Gerd Hoffmann , Paolo Bonzini , Laszlo Ersek Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190424073056.h0_4tcKTsOER0s95bly9ZE9_tfUtlaVrE_uyhIRsTBo@z> On 24/04/2019 03.16, Li Qiang wrote: >=20 > Thomas Huth > =E4=BA=8E2019=E5= =B9=B44=E6=9C=8824=E6=97=A5 > =E5=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=8812:29=E5=86=99=E9=81=93=EF=BC=9A >=20 > On 20/04/2019 12.00, Li Qiang wrote: > > Signed-off-by: Li Qiang > > > --- > >=C2=A0 tests/fw_cfg-test.c | 19 +++++++++++++++++++ > >=C2=A0 1 file changed, 19 insertions(+) > > > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > > index c22503619f..9f75dbb5f4 100644 > > --- a/tests/fw_cfg-test.c > > +++ b/tests/fw_cfg-test.c > > @@ -174,6 +174,24 @@ static void test_fw_cfg_boot_menu(void) > >=C2=A0 =C2=A0 =C2=A0 qtest_quit(s); > >=C2=A0 } > >=C2=A0 > > +static void test_fw_cfg_reboot_timeout(void) > > +{ > > +=C2=A0 =C2=A0 QFWCFG *fw_cfg; > > +=C2=A0 =C2=A0 QTestState *s; > > +=C2=A0 =C2=A0 uint32_t reboot_timeout =3D 0; > > +=C2=A0 =C2=A0 size_t filesize; > > + > > +=C2=A0 =C2=A0 s =3D qtest_init("-boot reboot-timeout=3D15"); > > +=C2=A0 =C2=A0 fw_cfg =3D pc_fw_cfg_init(s); > > + > > +=C2=A0 =C2=A0 filesize =3D qfw_cfg_get_file(fw_cfg, "etc/boot-fa= il-wait", > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0&reboot_timeout, sizeof(reboot_timeout)); > > +=C2=A0 =C2=A0 g_assert_cmpint(filesize, =3D=3D, sizeof(reboot_ti= meout)); > > +=C2=A0 =C2=A0 g_assert_cmpint(reboot_timeout, =3D=3D, 15); >=20 > Is this endianess-safe? Or do you need to byteswap reboot_timeout i= f the > host and guest endianess does not match? >=20 > Good question! >=20 > IIUC, the qemu fw_cfg store the 'file' entry data just in byte stream. > So there is no need > to consider the file's endianess. If when the file entry is stored > without considering endianess, > it will be ok to ignore the endianess. So for this patch, the > 'reboot_timeout' is ok as when we stored=C2=A0 > it we don't consider endianess. But for 'splash-time', when we stored > it=C2=A0 we convert it to little endian > so when we fetches it, we should also convert it from little endian to > cpu-endian. I just gave these patches a try on a big endian host, and the test fails indeed: $ QTEST_QEMU_BINARY=3Dx86_64-softmmu/qemu-system-x86_64 tests/fw_cfg-test /x86_64/fw_cfg/signature: OK /x86_64/fw_cfg/id: OK /x86_64/fw_cfg/uuid: OK /x86_64/fw_cfg/ram_size: OK /x86_64/fw_cfg/nographic: OK /x86_64/fw_cfg/nb_cpus: OK /x86_64/fw_cfg/max_cpus: OK /x86_64/fw_cfg/numa: OK /x86_64/fw_cfg/boot_menu: OK /x86_64/fw_cfg/reboot_timeout: ** ERROR:tests/fw_cfg-test.c:190:test_fw_cfg_reboot_timeout: assertion failed (reboot_timeout =3D=3D 15): (0 =3D=3D 15) Aborted =3D> it also fails for reboot_timeout already, not only for splash_time. > So I think we can have following choose: >=20 > 1. Don't consider the endianess, this is ok when emaulated target and > host target has the same endianess. Sorry, but that's not a real choice. qtests must also work when you e.g. run qemu-system-x86_64 on a big endian host. Thomas