From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, qemu-s390x@nongnu.org, cohuck@redhat.com,
laurent@vivier.eu
Subject: Re: [PATCH 2/3] linux-user/s390x: Clean up signal.c
Date: Wed, 28 Apr 2021 15:56:08 +0200 [thread overview]
Message-ID: <6de1399d-a945-62d0-190f-a7ebeceef833@redhat.com> (raw)
In-Reply-To: <20210428033204.133471-3-richard.henderson@linaro.org>
On 28.04.21 05:32, Richard Henderson wrote:
> The "save" routines from the kernel, which are currently
> commented out, are unnecessary in qemu. We can copy from
> env where the kernel needs special instructions.
>
> Drop the return value from restore_sigregs, as it cannot fail.
> Use __get_user return as input to trace, so that we properly
> bswap the value for the host.
>
> Reorder the function bodies to correspond to the kernel source.
> Fix the use of host addresses where guest addresses are needed.
> Drop the use of PSW_ADDR_AMODE, since we only support 64-bit.
> Set psw.mask properly for the signal handler.
> Use tswap_sigset in setup_rt_frame.
This would be a lot easier to review if this would be split up into
individual patches.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-04-28 14:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 3:32 [PATCH 0/3] linux-user/s390x: some signal fixes Richard Henderson
2021-04-28 3:32 ` [PATCH 1/3] linux-user/s390x: Fix sigframe types Richard Henderson
2021-04-28 13:53 ` David Hildenbrand
2021-04-28 3:32 ` [PATCH 2/3] linux-user/s390x: Clean up signal.c Richard Henderson
2021-04-28 13:56 ` David Hildenbrand [this message]
2021-04-28 3:32 ` [PATCH 3/3] linux-user/s390x: Handle vector regs in signal stack Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de1399d-a945-62d0-190f-a7ebeceef833@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).