Re: [PULL 0/5] Tracing patches

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 1/31/20 3:38 PM, Philippe Mathieu-Daudé wrote:
> On 1/31/20 2:57 PM, Peter Maydell wrote:
>> On Thu, 30 Jan 2020 at 21:38, Stefan Hajnoczi <stefanha@redhat.com> 
>> wrote:
>>>
>>> The following changes since commit 
>>> 928173659d6e5dc368284f73f90ea1d129e1f57d:
>>>
>>>    Merge remote-tracking branch 
>>> 'remotes/pmaydell/tags/pull-target-arm-20200130' into staging 
>>> (2020-01-30 16:19:04 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>>    https://github.com/stefanha/qemu.git tags/tracing-pull-request
>>>
>>> for you to fetch changes up to e144a605a614d22165000c69e8e1dc6986d45cd8:
>>>
>>>    qemu_set_log_filename: filename argument may be NULL (2020-01-30 
>>> 21:33:50 +0000)
>>>
>>> ----------------------------------------------------------------
>>> Pull request
>>>
>>> ----------------------------------------------------------------
>>>
>>> Peter Maydell (3):
>>>    docs/devel/tracing.txt: Recommend only
>>>      trace_event_get_state_backends()
>>>    memory.c: Use trace_event_get_state_backends()
>>>    hw/display/qxl.c: Use trace_event_get_state_backends()
>>>
>>> Philippe Mathieu-Daudé (1):
>>>    Makefile: Keep trace-events-subdirs ordered
>>>
>>> Salvador Fandino (1):
>>>    qemu_set_log_filename: filename argument may be NULL
>>
>> Here's a weird one -- with this pullreq applied I
>> see a new warning running check-tcg on the linux-user
>> static config build:
>>
>>    TEST    linux-test on aarch64
>>    TEST    testthread on aarch64
>>    TEST    float_madds on aarch64
>>    DIFF    float_madds.out with
>> /home/petmay01/linaro/qemu-for-merges/tests/tcg/aarch64/float_ma
>> dds.ref
>>    TEST    fcvt on aarch64
>> warning: TCG temporary leaks before 0000000000400a0c
>>    DIFF    fcvt.out with
>> /home/petmay01/linaro/qemu-for-merges/tests/tcg/aarch64/fcvt.ref
>>    TEST    pauth-1 on aarch64
>>    TEST    pauth-2 on aarch64
>>
>> but I'm not sure why any of the patches here would have
>> provoked that, unless they're now causing a log message
>> that would previously have been suppressed or directed
>> somewhere else to be emitted.
> 
> Looking at the last patch "qemu_set_log_filename: filename argument may 
> be NULL", maybe these were previously logged into a ./'(null)' logfile?

Forget that comment, I need some caffeine.