From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8188AC4167B for ; Fri, 1 Dec 2023 07:17:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8xlO-0003Cd-GT; Fri, 01 Dec 2023 02:16:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8xlF-00038u-6i; Fri, 01 Dec 2023 02:16:29 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8xlC-0004NW-V3; Fri, 01 Dec 2023 02:16:28 -0500 Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B1725a0004180; Fri, 1 Dec 2023 07:15:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=BzkqJ/jGQ8feZTMTV7kBM2CKnfMMKrkrySy6iUP9EuY=; b=b+xga7mwfs1rp6LEevn9sUHSCU1lMKC/Z/EnZFVSkTZqk7CHQROyPzsnuQdIM07JAGOd ya+rGqq00S4Crr3b2meBlGLmSR+zVLKt6N0RKDFEL0B0+PyddOMnJ1Oo3KMNYy0V45Tp zQl06ERE0CoEmNthAoELlOyVtJJ5tOVa5/qwQCWWe44HfrE8ufDG2+WNPURfGtiA7LjI gEQQwLy0ElzkEJ/RfK3dlxHsbtQvtJbXCubTiiy4RG3biUGoEqTvt7IqDZAaduT8B7ug IPbSIbm/F1XOJB6WbUJbwyRiB0naqI1VwIbtR2szxG9CAwjLNMBiE/wFu+M9Q33M+Xk/ eA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uqar7gaus-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 07:15:41 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3B17FebO014948; Fri, 1 Dec 2023 07:15:40 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uqar7ga27-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 07:15:40 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3B16Ye5v029654; Fri, 1 Dec 2023 07:11:06 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ukv8p3h96-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 07:11:06 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3B17B5Ah30016124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Dec 2023 07:11:05 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2A81A58052; Fri, 1 Dec 2023 07:11:05 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8CEAB58054; Fri, 1 Dec 2023 07:10:35 +0000 (GMT) Received: from [9.43.126.227] (unknown [9.43.126.227]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 1 Dec 2023 07:10:35 +0000 (GMT) Message-ID: <6debe854-55df-e901-e154-5ed390178c74@linux.ibm.com> Date: Fri, 1 Dec 2023 12:40:33 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/6] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to QEMU_BQL_LOCK_GUARD Content-Language: en-US To: Stefan Hajnoczi , Ilya Leoshkevich Cc: qemu-devel@nongnu.org, Jean-Christophe Dubois , Fabiano Rosas , qemu-s390x@nongnu.org, Song Gao , Marcel Apfelbaum , Thomas Huth , Hyman Huang , Marcelo Tosatti , David Woodhouse , Andrey Smirnov , Peter Maydell , Kevin Wolf , Artyom Tarasenko , Mark Cave-Ayland , Max Filippov , Alistair Francis , Paul Durrant , Jagannathan Raman , Juan Quintela , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-arm@nongnu.org, Jason Wang , Gerd Hoffmann , Hanna Reitz , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , BALATON Zoltan , Daniel Henrique Barboza , Elena Ufimtseva , Aurelien Jarno , Hailiang Zhang , Roman Bolshakov , Huacai Chen , Fam Zheng , Eric Blake , Jiri Slaby , Alexander Graf , Liu Zhiwei , Weiwei Li , Eric Farman , Stafford Horne , David Hildenbrand , Markus Armbruster , Reinoud Zandijk , Palmer Dabbelt , Cameron Esfahani , xen-devel@lists.xenproject.org, Pavel Dovgalyuk , qemu-riscv@nongnu.org, Aleksandar Rikalo , John Snow , Sunil Muthuswamy , Michael Roth , David Gibson , "Michael S. Tsirkin" , Richard Henderson , Bin Meng , Stefano Stabellini , kvm@vger.kernel.org, qemu-block@nongnu.org, Halil Pasic , Peter Xu , Anthony Perard , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Eduardo Habkost , Paolo Bonzini , Vladimir Sementsov-Ogievskiy , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-ppc@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Christian Borntraeger , Akihiko Odaki , Leonardo Bras , Nicholas Piggin , Jiaxun Yang References: <20231129212625.1051502-1-stefanha@redhat.com> <20231129212625.1051502-3-stefanha@redhat.com> <20231130202732.GA1184658@fedora> From: Harsh Prateek Bora In-Reply-To: <20231130202732.GA1184658@fedora> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: S1sEqcNGAK1f1yUwyiWHNf41PAnYA7MY X-Proofpoint-GUID: B-XJS9KsqjYFS8Hl-N4F0TWzVhOEzlLk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-01_04,2023-11-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 phishscore=0 adultscore=0 mlxlogscore=778 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312010044 Received-SPF: pass client-ip=148.163.156.1; envelope-from=harshpb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.177, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/1/23 01:57, Stefan Hajnoczi wrote: > On Thu, Nov 30, 2023 at 10:14:47AM +0100, Ilya Leoshkevich wrote: >> On Wed, 2023-11-29 at 16:26 -0500, Stefan Hajnoczi wrote: >>> The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) >>> instead, it is already widely used and unambiguous. >>> >>> Signed-off-by: Stefan Hajnoczi >>> --- >>>  include/qemu/main-loop.h  | 20 ++++++++++---------- >>>  hw/i386/kvm/xen_evtchn.c  | 14 +++++++------- >>>  hw/i386/kvm/xen_gnttab.c  |  2 +- >>>  hw/mips/mips_int.c        |  2 +- >>>  hw/ppc/ppc.c              |  2 +- >>>  target/i386/kvm/xen-emu.c |  2 +- >>>  target/ppc/excp_helper.c  |  2 +- >>>  target/ppc/helper_regs.c  |  2 +- >>>  target/riscv/cpu_helper.c |  4 ++-- >>>  9 files changed, 25 insertions(+), 25 deletions(-) >>> >>> diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h >>> index d6f75e57bd..0b6a3e4824 100644 >>> --- a/include/qemu/main-loop.h >>> +++ b/include/qemu/main-loop.h >>> @@ -344,13 +344,13 @@ void qemu_bql_lock_impl(const char *file, int >>> line); >>>  void qemu_bql_unlock(void); >>> >>>  /** >>> - * QEMU_IOTHREAD_LOCK_GUARD >>> + * QEMU_BQL_LOCK_GUARD >>>   * >>> - * Wrap a block of code in a conditional >>> qemu_mutex_{lock,unlock}_iothread. >>> + * Wrap a block of code in a conditional qemu_bql_{lock,unlock}. >>>   */ >>> -typedef struct IOThreadLockAuto IOThreadLockAuto; >>> +typedef struct BQLLockAuto BQLLockAuto; >>> >>> -static inline IOThreadLockAuto *qemu_iothread_auto_lock(const char >>> *file, >>> +static inline BQLLockAuto *qemu_bql_auto_lock(const char *file, >>>                                                          int line) >> >> The padding is not correct anymore. > > Good point, I didn't check the formatting after search-and-replace. I > will fix this across the patch series in v2. > Yeh, some comments in 5/6 and 6/6 can also make full use of 80 char width after search-replace effect. regards, Harsh > Stefan