From: Richard Henderson <richard.henderson@linaro.org>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Stefan Hajnoczi <stefanha@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/7] trace: Add event "guest_inst_before"
Date: Wed, 13 Sep 2017 10:02:58 -0700 [thread overview]
Message-ID: <6ded11bd-dcae-2e98-5af6-3f2cc77706d8@linaro.org> (raw)
In-Reply-To: <150506035158.19604.740046564057160055.stgit@frigg.lan>
On 09/10/2017 09:19 AM, Lluís Vilanova wrote:
> while (true) {
> + target_ulong pc_insn = db->pc_next;
Why not just "pc"?
> +
> db->num_insns++;
> ops->insn_start(db, cpu);
> tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */
> @@ -96,6 +98,7 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,
> if (db->num_insns == 1) {
> trace_guest_bbl_before_tcg(cpu, tcg_ctx.tcg_env, db->pc_first);
> }
> + trace_guest_inst_before_tcg(cpu, tcg_ctx.tcg_env, pc_insn);
I prefer "insn" over "inst". There are enough other words that begin with
"inst" (e.g. instance) to possibly be confusing. Either that or it's my 20
years working on gcc that ingrained "insn". ;-)
r~
next prev parent reply other threads:[~2017-09-13 17:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 16:11 [Qemu-devel] [PATCH 0/7] trace: Add guest code events Lluís Vilanova
2017-09-10 16:15 ` [Qemu-devel] [PATCH 1/7] trace: Add event "guest_bbl_before" Lluís Vilanova
2017-09-13 16:59 ` Richard Henderson
2017-09-14 14:21 ` Lluís Vilanova
2017-09-10 16:19 ` [Qemu-devel] [PATCH 2/7] trace: Add event "guest_inst_before" Lluís Vilanova
2017-09-13 17:02 ` Richard Henderson [this message]
2017-09-14 14:40 ` Lluís Vilanova
2017-09-10 16:23 ` [Qemu-devel] [PATCH 3/7] trace: Add event "guest_inst_info_before" Lluís Vilanova
2017-09-13 17:07 ` Richard Henderson
2017-09-14 14:59 ` Lluís Vilanova
2017-09-14 16:12 ` Richard Henderson
2017-09-10 16:27 ` [Qemu-devel] [PATCH 4/7] tcg: Add support for "inlining" regions of code Lluís Vilanova
2017-09-13 17:09 ` Richard Henderson
2017-09-14 15:20 ` Lluís Vilanova
2017-09-14 16:15 ` Richard Henderson
2017-09-15 12:55 ` Lluís Vilanova
2017-09-26 16:31 ` Lluís Vilanova
2017-09-26 16:52 ` Richard Henderson
2017-09-10 16:31 ` [Qemu-devel] [PATCH 5/7] trace: Add event "guest_bbl_after" Lluís Vilanova
2017-09-13 17:34 ` Richard Henderson
2017-09-14 15:20 ` Lluís Vilanova
2017-09-14 16:16 ` Richard Henderson
2017-09-10 16:35 ` [Qemu-devel] [PATCH 6/7] trace: Add event "guest_inst_after" Lluís Vilanova
2017-09-13 18:01 ` Richard Henderson
2017-09-14 16:23 ` Lluís Vilanova
2017-09-10 16:39 ` [Qemu-devel] [PATCH 7/7] trace: Add event "guest_inst_info_after" Lluís Vilanova
2017-09-13 18:03 ` Richard Henderson
2017-09-10 16:45 ` [Qemu-devel] [PATCH 0/7] trace: Add guest code events no-reply
2017-09-13 14:36 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ded11bd-dcae-2e98-5af6-3f2cc77706d8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).