qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: 20230524082037.1620952-1-thuth@redhat.com, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Leif Lindholm <quic_llindhol@quicinc.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH 3/3] hw/arm/sbsa-ref: use MachineClass->default_display
Date: Wed, 24 May 2023 11:22:05 +0200	[thread overview]
Message-ID: <6dfa9cdb-2efb-8991-e810-f08b4a215321@redhat.com> (raw)
In-Reply-To: <20230524083913.696175-3-marcin.juszkiewicz@linaro.org>

On 24/05/2023 10.39, Marcin Juszkiewicz wrote:
> Mark the default graphica via the new MachineClass->default_display
> setting so that the machine-defaults code in vl.c can decide whether the
> default graphics is usable or not (for example when compiling with the
> "--without-default-devices" configure switch).
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
>   hw/arm/sbsa-ref.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 9a3d77d6b6..30ce7f7db4 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -649,7 +649,7 @@ static void create_pcie(SBSAMachineState *sms)
>           }
>   
>           if (vga_interface_type != VGA_NONE) {
> -            pci_create_simple(pci->bus, -1, "bochs-display");
> +            pci_create_simple(pci->bus, -1, mc->default_display);

Based-on: <20230524082037.1620952-1-thuth@redhat.com>
(otherwise you don't have the "mc" variable available here)

>           }
>       }
>   
> @@ -865,6 +865,7 @@ static void sbsa_ref_class_init(ObjectClass *oc, void *data)
>       mc->default_ram_size = 1 * GiB;
>       mc->default_ram_id = "sbsa-ref.ram";
>       mc->default_cpus = 4;
> +    mc->default_display = "bochs-display";

I guess this might not work as expected yet...

The code in vl.c looks through the vga_interfaces[] array and warns if it 
cannot find the default_display there... and since there is no entry for the 
bochs-display in that array, you likely now always get this warning message, 
even if it is available?

So I think you either have to drop this patch, or you've got to add an entry 
for the bochs-display to vga_interfaces[], too.

  Thomas



  reply	other threads:[~2023-05-24  9:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 10:53 [PATCH v2] hw/arm/sbsa-ref: add GIC node into DT Marcin Juszkiewicz
2023-05-19 14:29 ` Leif Lindholm
2023-05-23 13:50 ` Peter Maydell
2023-05-23 15:56   ` [PATCH 1/2] docs: sbsa: correct graphics card name Marcin Juszkiewicz
2023-05-23 15:56     ` [PATCH 2/2] docs: sbsa: document platform version changes Marcin Juszkiewicz
2023-05-23 17:11     ` [PATCH 1/2] docs: sbsa: correct graphics card name Thomas Huth
2023-05-23 17:28       ` [PATCH v2 1/3] " Marcin Juszkiewicz
2023-05-23 17:28         ` [PATCH v2 2/3] docs: sbsa: document platform version changes Marcin Juszkiewicz
2023-05-23 17:28         ` [PATCH v2 3/3] hw/arm/Kconfig: sbsa-ref uses Bochs display Marcin Juszkiewicz
2023-05-23 18:42           ` Thomas Huth
2023-05-23 18:29         ` [PATCH v2 1/3] docs: sbsa: correct graphics card name Thomas Huth
2023-05-23 17:30       ` [PATCH 1/2] " Marcin Juszkiewicz
2023-05-23 18:41         ` Thomas Huth
2023-05-25 10:05           ` Peter Maydell
2023-05-25 10:32             ` Thomas Huth
2023-05-25 10:44               ` Peter Maydell
2023-05-25 10:53                 ` Thomas Huth
2023-05-25 11:06                 ` Mark Cave-Ayland
2023-05-25 11:39                   ` Peter Maydell
2023-05-25 11:49                     ` Thomas Huth
2023-05-24  8:39       ` [PATCH 1/3] hw/arm/sbsa-ref: honor "-vga none" argument Marcin Juszkiewicz
2023-05-24  8:39         ` [PATCH 2/3] hw/arm/sbsa-ref: add gfx card only if we have pci Marcin Juszkiewicz
2023-05-24  8:59           ` Thomas Huth
2023-05-24  9:27           ` Thomas Huth
2023-05-24  8:39         ` [PATCH 3/3] hw/arm/sbsa-ref: use MachineClass->default_display Marcin Juszkiewicz
2023-05-24  9:22           ` Thomas Huth [this message]
2023-05-24  9:25           ` Thomas Huth
2023-05-24  8:51         ` [PATCH 1/3] hw/arm/sbsa-ref: honor "-vga none" argument Thomas Huth
2023-05-24  9:27         ` Thomas Huth
2023-05-24 10:18       ` [PATCH v2 1/5] hw/arm: Use MachineClass->default_nic in the sbsa-ref machine Marcin Juszkiewicz
2023-05-24 10:18         ` [PATCH v2 2/5] Add Bochs to list of vga_interfaces Marcin Juszkiewicz
2023-05-24 10:18         ` [PATCH v2 3/5] hw/arm/sbsa-ref: honor "-vga none" argument Marcin Juszkiewicz
2023-05-24 10:18         ` [PATCH v2 4/5] hw/arm/sbsa-ref: add gfx card only if we have pci Marcin Juszkiewicz
2023-05-24 10:18         ` [PATCH v2 5/5] hw/arm/sbsa-ref: use MachineClass->default_display Marcin Juszkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6dfa9cdb-2efb-8991-e810-f08b4a215321@redhat.com \
    --to=thuth@redhat.com \
    --cc=20230524082037.1620952-1-thuth@redhat.com \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quic_llindhol@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).