From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state
Date: Wed, 23 Oct 2019 10:49:24 -0400 [thread overview]
Message-ID: <6e06dede-2470-92e1-eba9-40646ed56af0@linaro.org> (raw)
In-Reply-To: <CAFEAcA-Xj-6CdVzgfcVONipApD5b5PZ84nPnvbbOQjQkqQLnqA@mail.gmail.com>
On 10/22/19 11:38 AM, Peter Maydell wrote:
> Turns out this asserts in qemu-armeb :-(
>
> /home/petmay01/linaro/qemu-for-merges/build/all-linux-static/armeb-linux-user/qemu-armeb
> -L ./gnemul/qemu-armeb armeb/ls -l dummyfile
> qemu-armeb: /home/petmay01/linaro/qemu-for-merges/target/arm/helper.c:11267:
> cpu_get_tb_cpu_state: Assertion `flags ==
> rebuild_hflags_internal(env)' failed.
> qemu: uncaught target signal 11 (Segmentation fault) - core dumped
> Segmentation fault (core dumped)
>
> Dropping this series again for the moment.
Argh! I had forgotten that we have no testing of armeb in check-tcg.
Yes, I see now that we need a recompute in linux-user/{aarch64,arm}/cpu_loop.c
specific to TARGET_WORDS_BIGENDIAN.
r~
next prev parent reply other threads:[~2019-10-23 14:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 17:44 [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state Richard Henderson
2019-10-18 17:44 ` [PATCH v8 01/22] target/arm: Split out rebuild_hflags_common Richard Henderson
2019-10-18 17:44 ` [PATCH v8 02/22] target/arm: Split out rebuild_hflags_a64 Richard Henderson
2019-10-18 17:44 ` [PATCH v8 03/22] target/arm: Split out rebuild_hflags_common_32 Richard Henderson
2019-10-18 17:44 ` [PATCH v8 04/22] target/arm: Split arm_cpu_data_is_big_endian Richard Henderson
2019-10-18 17:44 ` [PATCH v8 05/22] target/arm: Split out rebuild_hflags_m32 Richard Henderson
2019-10-18 17:44 ` [PATCH v8 06/22] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state Richard Henderson
2019-10-18 17:44 ` [PATCH v8 07/22] target/arm: Split out rebuild_hflags_a32 Richard Henderson
2019-10-18 17:44 ` [PATCH v8 08/22] target/arm: Split out rebuild_hflags_aprofile Richard Henderson
2019-10-18 17:44 ` [PATCH v8 09/22] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state Richard Henderson
2019-10-18 17:44 ` [PATCH v8 10/22] target/arm: Simplify set of PSTATE_SS " Richard Henderson
2019-10-18 17:44 ` [PATCH v8 11/22] target/arm: Hoist computation of TBFLAG_A32.VFPEN Richard Henderson
2019-10-18 17:44 ` [PATCH v8 12/22] target/arm: Add arm_rebuild_hflags Richard Henderson
2019-10-18 17:44 ` [PATCH v8 13/22] target/arm: Split out arm_mmu_idx_el Richard Henderson
2019-10-18 17:44 ` [PATCH v8 14/22] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state Richard Henderson
2019-10-18 17:44 ` [PATCH v8 15/22] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32}) Richard Henderson
2019-10-18 17:44 ` [PATCH v8 16/22] target/arm: Rebuild hflags at EL changes Richard Henderson
2019-10-18 17:44 ` [PATCH v8 17/22] target/arm: Rebuild hflags at MSR writes Richard Henderson
2019-10-18 17:44 ` [PATCH v8 18/22] target/arm: Rebuild hflags at CPSR writes Richard Henderson
2019-10-18 17:44 ` [PATCH v8 19/22] target/arm: Rebuild hflags at Xscale SCTLR writes Richard Henderson
2019-10-18 17:44 ` [PATCH v8 20/22] target/arm: Rebuild hflags for M-profile Richard Henderson
2019-10-18 17:44 ` [PATCH v8 21/22] target/arm: Rebuild hflags for M-profile NVIC Richard Henderson
2019-10-18 17:44 ` [PATCH v8 22/22] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state Richard Henderson
2019-10-22 12:47 ` [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state Peter Maydell
2019-10-22 15:38 ` Peter Maydell
2019-10-23 14:49 ` Richard Henderson [this message]
2019-10-23 15:17 ` Alex Bennée
2019-10-23 16:13 ` Richard Henderson
2019-10-23 18:06 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e06dede-2470-92e1-eba9-40646ed56af0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).