From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, bharata@linux.ibm.com
Subject: Re: [PATCH 1/8] softfloat: Use mulu64 for mul64To128
Date: Thu, 24 Sep 2020 09:32:25 +0200 [thread overview]
Message-ID: <6e246c0f-212a-3da7-1959-ae72d0669191@redhat.com> (raw)
In-Reply-To: <20200924012453.659757-2-richard.henderson@linaro.org>
On 24.09.20 03:24, Richard Henderson wrote:
> Via host-utils.h, we use a host widening multiply for
> 64-bit hosts, and a common subroutine for 32-bit hosts.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/fpu/softfloat-macros.h | 24 ++++--------------------
> 1 file changed, 4 insertions(+), 20 deletions(-)
>
> diff --git a/include/fpu/softfloat-macros.h b/include/fpu/softfloat-macros.h
> index a35ec2893a..57845f8af0 100644
> --- a/include/fpu/softfloat-macros.h
> +++ b/include/fpu/softfloat-macros.h
> @@ -83,6 +83,7 @@ this code that are retained.
> #define FPU_SOFTFLOAT_MACROS_H
>
> #include "fpu/softfloat-types.h"
> +#include "qemu/host-utils.h"
>
> /*----------------------------------------------------------------------------
> | Shifts `a' right by the number of bits given in `count'. If any nonzero
> @@ -515,27 +516,10 @@ static inline void
> | `z0Ptr' and `z1Ptr'.
> *----------------------------------------------------------------------------*/
>
> -static inline void mul64To128( uint64_t a, uint64_t b, uint64_t *z0Ptr, uint64_t *z1Ptr )
> +static inline void
> +mul64To128(uint64_t a, uint64_t b, uint64_t *z0Ptr, uint64_t *z1Ptr)
> {
> - uint32_t aHigh, aLow, bHigh, bLow;
> - uint64_t z0, zMiddleA, zMiddleB, z1;
> -
> - aLow = a;
> - aHigh = a>>32;
> - bLow = b;
> - bHigh = b>>32;
> - z1 = ( (uint64_t) aLow ) * bLow;
> - zMiddleA = ( (uint64_t) aLow ) * bHigh;
> - zMiddleB = ( (uint64_t) aHigh ) * bLow;
> - z0 = ( (uint64_t) aHigh ) * bHigh;
> - zMiddleA += zMiddleB;
> - z0 += ( ( (uint64_t) ( zMiddleA < zMiddleB ) )<<32 ) + ( zMiddleA>>32 );
> - zMiddleA <<= 32;
> - z1 += zMiddleA;
> - z0 += ( z1 < zMiddleA );
> - *z1Ptr = z1;
> - *z0Ptr = z0;
> -
> + mulu64(z1Ptr, z0Ptr, a, b);
> }
>
> /*----------------------------------------------------------------------------
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-09-24 7:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 1:24 [PATCH 0/8] softfloat: Implement float128_muladd Richard Henderson
2020-09-24 1:24 ` [PATCH 1/8] softfloat: Use mulu64 for mul64To128 Richard Henderson
2020-09-24 7:32 ` David Hildenbrand [this message]
2020-09-24 1:24 ` [PATCH 2/8] softfloat: Use int128.h for some operations Richard Henderson
2020-09-24 7:35 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 3/8] softfloat: Tidy a * b + inf return Richard Henderson
2020-09-24 7:37 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 4/8] softfloat: Add float_cmask and constants Richard Henderson
2020-09-24 7:40 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 5/8] softfloat: Inline pick_nan_muladd into its caller Richard Henderson
2020-09-24 7:42 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 6/8] softfloat: Implement float128_muladd Richard Henderson
2020-09-24 7:56 ` David Hildenbrand
2020-09-24 13:30 ` Richard Henderson
2020-09-25 9:17 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 7/8] softfloat: Use x86_64 assembly for {add,sub}{192,256} Richard Henderson
2020-09-24 1:24 ` [PATCH 8/8] softfloat: Use aarch64 " Richard Henderson
2020-09-24 8:00 ` [PATCH 0/8] softfloat: Implement float128_muladd David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e246c0f-212a-3da7-1959-ae72d0669191@redhat.com \
--to=david@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bharata@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).